8268056: Update java.net and java.nio to use switch expressions

[pconcannon]

Hi,

Could someone please review my code for updating the code in the java.net and java.nio packages to make use of the switch expressions?

Kind regards,
Patrick

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268056: Update java.net and java.nio to use switch expressions

Reviewers

• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to 433b02a
• Michael McMahon (@Michael-Mc-Mahon - Reviewer) ⚠️ Review applies to 433b02a
• Chris Hegarty (@ChrisHegarty - Reviewer) ⚠️ Review applies to 433b02a
• Iris Clark (@irisclark - Reviewer) ⚠️ Review applies to 0f7614e
• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to dec6d20

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4285/head:pull/4285
$ git checkout pull/4285

Update a local copy of the PR:
$ git checkout pull/4285
$ git pull https://git.openjdk.java.net/jdk pull/4285/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4285

View PR using the GUI difftool:
$ git pr show -t 4285

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4285.diff

[bridgekeeper]

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pconcannon The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (ffeb4c56)
• 05: Full - Incremental (dec6d20b)
• 04: Full - Incremental (0f7614e2)
• 03: Full - Incremental (433b02a0)
• 02: Full - Incremental (23f53c52)
• 01: Full - Incremental (2f179b52)
• 00: Full (33cc9517)

[AlanBateman]

/label add nio

[openjdk]

@AlanBateman
The nio label was successfully added.

[openjdk]

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268056: Update java.net and java.nio to use switch expressions

Reviewed-by: dfuchs, michaelm, chegar, iris, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Michael-Mc-Mahon]

LGTM

[AlanBateman]

Updated patch looks okay. I'm not 100% sure that it's a significant improvement over the original code but I think this is the nature of more complex switch statements.

[pconcannon]

/integrate

[openjdk]

@pconcannon Since your change was applied there has been 1 commit pushed to the master branch:

• 9cfd560: 8267663: [vector] Add unsigned comparison operators on AArch64

Your commit was automatically rebased without conflicts.

Pushed as commit 4388959.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.