-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8253470: Javadoc clean up in Filter and Headers #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into |
@pconcannon The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this issue Patrick!
A few comments below:
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java
Outdated
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java
Outdated
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java
Outdated
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java
Outdated
Show resolved
Hide resolved
74d45b9
to
bfff3c8
Compare
@pconcannon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java
Outdated
Show resolved
Hide resolved
src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java
Outdated
Show resolved
Hide resolved
/integrate |
@pconcannon Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 0fd41c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean up in Filter and Headers' ?
This fix is set of formatting changes intended to clean up the javadoc of the following classes :
com.sun.net.httpserver.Filter
com.sun.net.httpserver.Filter.Chain
com.sun.net.httpserver.Headers
This issue is a sub-task of JDK-8252822
Kind regards,
Patrick
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/429/head:pull/429
$ git checkout pull/429