Skip to content

8253470: Javadoc clean up in Filter and Headers #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Sep 30, 2020

Hi,

Could someone please review my doc-only fix for JDK-8253470 - 'Javadoc clean up in Filter and Headers' ?

This fix is set of formatting changes intended to clean up the javadoc of the following classes :

com.sun.net.httpserver.Filter
com.sun.net.httpserver.Filter.Chain
com.sun.net.httpserver.Headers

This issue is a sub-task of JDK-8252822

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/429/head:pull/429
$ git checkout pull/429

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2020

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2020
@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Sep 30, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2020

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this issue Patrick!

A few comments below:

@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253470: Javadoc clean up in Filter and Headers

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b8966e1: 8253928: G1: Remove G1ConcurrentMarkThread::set_in_progress declaration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2020
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 1, 2020
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 2, 2020
@pconcannon
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 2, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 2, 2020
@openjdk
Copy link

openjdk bot commented Oct 2, 2020

@pconcannon Since your change was applied there have been 2 commits pushed to the master branch:

  • f686a38: 8253926: Use extra_size correctly in anon_mmap_aligned
  • b8966e1: 8253928: G1: Remove G1ConcurrentMarkThread::set_in_progress declaration

Your commit was automatically rebased without conflicts.

Pushed as commit 0fd41c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pconcannon pconcannon deleted the JDK-8253470 branch October 5, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants