Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8263389 IGV: Zooming changes the point that is currently centered #4291

Closed
wants to merge 2 commits into from

Conversation

jtfuller111
Copy link
Contributor

@jtfuller111 jtfuller111 commented Jun 1, 2021

Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming now works as expected.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263389: IGV: Zooming changes the point that is currently centered

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4291/head:pull/4291
$ git checkout pull/4291

Update a local copy of the PR:
$ git checkout pull/4291
$ git pull https://git.openjdk.java.net/jdk pull/4291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4291

View PR using the GUI difftool:
$ git pr show -t 4291

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4291.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jun 1, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2021

Hi @jtfuller111, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jtfuller111" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@jtfuller111
Copy link
Contributor Author

jtfuller111 commented Jun 1, 2021

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jun 1, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented Jun 1, 2021

@jtfuller111 The following labels will be automatically applied to this pull request:

  • build
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jun 1, 2021
@robilad
Copy link

robilad commented Jun 1, 2021

Hi, please send an e-mail to Dalibor.topic@oracle.com so that I can mark your account as verified.

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jun 4, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2021

Webrevs

@jtfuller111
Copy link
Contributor Author

jtfuller111 commented Jun 10, 2021

Hello, could anyone kindly take a look at this?

@reinrich
Copy link
Contributor

reinrich commented Jun 15, 2021

Hi @jtfuller111,

I've tested the fix and found that it eliminates the random moves of the view port when zooming. Thumbs up for that. It still changes the point that is centered though. You might want to fix that also if possible.

Thanks, Richard.

@jtfuller111
Copy link
Contributor Author

jtfuller111 commented Jun 16, 2021

Hi @jtfuller111,

I've tested the fix and found that it eliminates the random moves of the view port when zooming. Thumbs up for that. It still changes the point that is centered though. You might want to fix that also if possible.

Thanks, Richard.

Hello! I pushed a change to also keeps the current center point centered when zooming.

Copy link
Contributor

@reinrich reinrich left a comment

The fix looks good to me.

Thanks, Richard.

@openjdk
Copy link

openjdk bot commented Jun 16, 2021

@jtfuller111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263389: IGV: Zooming changes the point that is currently centered

Reviewed-by: rrich, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 438 new commits pushed to the master branch:

  • 1ac8dee: 8269615: Fix for 8263640 broke Windows build
  • 7ca753b: 8269268: JDWP: Properly fix thread lookup assert in findThread()
  • 7a23c9c: 8260540: serviceability/jdwp/AllModulesCommandTest.java failed with "Debuggee error: 'ERROR: transport error 202: bind failed: Address already in use'"
  • c1e2a29: 8263640: hs_err improvement: handle class path longer than O_BUFLEN
  • bb42d75: 8269417: Minor clarification on NonblockingQueue utility
  • e238cbd: 8269530: runtime/ParallelLoad/ParallelSuperTest.java timeout
  • 3f2c372: 8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC
  • a977157: 8261579: AArch64: Support for weaker memory ordering in Atomic
  • ee1e202: 8268821: Split systemDictionaryShared.cpp
  • 03d54e6: Merge
  • ... and 428 more: https://git.openjdk.java.net/jdk/compare/ccfcd926674ee0bd88f34b16b489abe008169b11...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@reinrich, @neliasso) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 16, 2021
@jtfuller111
Copy link
Contributor Author

jtfuller111 commented Jun 24, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 24, 2021
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@jtfuller111
Your change (at version fcfb23d) is now ready to be sponsored by a Committer.

@reinrich
Copy link
Contributor

reinrich commented Jun 28, 2021

Hi @jtfuller111,
I'd offer to sponsor your fix. We should wait for a 2nd review though.
Thanks, Richard.

Copy link

@neliasso neliasso left a comment

Looks good.

@TobiHartmann
Copy link
Member

TobiHartmann commented Jul 5, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 5, 2021

Going to push as commit 164eff8.
Since your change was applied there have been 515 commits pushed to the master branch:

  • 371d996: 8269700: source level for IntelliJ JDK project is set incorrectly
  • 8a7b380: 8269124: Update java.time to use switch expressions (part II)
  • 675a952: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work
  • 4da52ea: 8269004: Implement ResizableResourceHashtable
  • 390d102: 8269652: Factor out the common code for creating system j.l.Thread objects
  • 17f53f2: Merge
  • 1c18f91: 8269768: JFR Terminology Refresh
  • 6f0e8e7: 8269775: compiler/codegen/ClearArrayTest.java failed with "assert(false) failed: bad AD file"
  • c4ea13e: 8269543: The warning for System::setSecurityManager should only appear once for each caller
  • 2db9005: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • ... and 505 more: https://git.openjdk.java.net/jdk/compare/ccfcd926674ee0bd88f34b16b489abe008169b11...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 5, 2021
@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 5, 2021
@openjdk
Copy link

openjdk bot commented Jul 5, 2021

@TobiHartmann @jtfuller111 Pushed as commit 164eff8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
5 participants