Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267861: Update SourceVersion with new language features in 16 and 17 #4294

Closed
wants to merge 1 commit into from

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Jun 1, 2021

Update SourceVersion constants for 16 and 17 with language features for those releases.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267861: Update SourceVersion with new language features in 16 and 17

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4294/head:pull/4294
$ git checkout pull/4294

Update a local copy of the PR:
$ git checkout pull/4294
$ git pull https://git.openjdk.java.net/jdk pull/4294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4294

View PR using the GUI difftool:
$ git pr show -t 4294

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4294.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 1, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 1, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler label Jun 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 1, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267861: Update SourceVersion with new language features in 16 and 17

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Jun 2, 2021

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jddarcy Pushed as commit 00c7aee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the 8267861 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants