Skip to content

8235229: Compilation against a modular, multi-release JAR erroneous with --release #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8235229: Compilation against a modular, multi-release JAR erroneous with --release #43

wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Sep 7, 2020 •
edited by openjdk bot
Loading

A combination of a multi-release modular jar and --release option does not work well, because the appropriate file manager does not have a multi-release option set. The proposal is to set the multi-release option to the file manager.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8235229: Compilation against a modular, multi-release JAR erroneous with --release

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/43/head:pull/43
$ git checkout pull/43

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 7, 2020

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 7, 2020
@openjdk
Copy link

openjdk bot commented Sep 7, 2020

@lahodaj The following label will be automatically applied to this pull request: compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Sep 7, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 7, 2020

Webrevs

vicente-romero-oracle
vicente-romero-oracle approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@openjdk
Copy link

openjdk bot commented Sep 8, 2020 •
edited
Loading

@lahodaj This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8235229: Compilation against a modular, multi-release JAR erroneous with --release

Reviewed-by: vromero
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 37 commits pushed to the master branch:

  • 382b8fe: 8240751: Shenandoah: fold ShenandoahTracer definition
  • c98417e: 8250840: some tests use --enable-preview unnecessarily
  • c655b70: 8252916: Newline in object field values list of ScopeDesc should be removed
  • 30fa8d5: 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
  • 26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions
  • e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/ae5a6dde2d77680da5cf4b64c76ab2b4059d3fc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 382b8fedf551a85a7a79b1fcdf38356493ec5d7e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2020
@lahodaj
Copy link
Contributor Author

lahodaj commented Sep 9, 2020

/integrate

@openjdk openjdk bot closed this Sep 9, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 9, 2020
@openjdk
Copy link

openjdk bot commented Sep 9, 2020

@lahodaj Since your change was applied there have been 37 commits pushed to the master branch:

  • 382b8fe: 8240751: Shenandoah: fold ShenandoahTracer definition
  • c98417e: 8250840: some tests use --enable-preview unnecessarily
  • c655b70: 8252916: Newline in object field values list of ScopeDesc should be removed
  • 30fa8d5: 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
  • 26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions
  • e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests
  • 704f784: 8252871: fatal error: must own lock JvmtiThreadState_lock
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/ae5a6dde2d77680da5cf4b64c76ab2b4059d3fc4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5fef8dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 9, 2020
@azvegint azvegint mentioned this pull request Nov 17, 2022
Closed
3 tasks
caojoshua pushed a commit to caojoshua/jdk that referenced this pull request Jun 1, 2023
@navyxliu
JVM-2031: Prevent PEA materialization takes place in side of a loop (o…
cbccf0a 
…penjdk#43)

* JVM-2031: Prevent PEA materialization takes place in side of a loop

* Don't create phi node in MergeProcessor if m and n are same.

---------

Co-authored-by: Xin Liu <xxinliu@amazon.com>
robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023
@luhenry
8295383: Implement SHA-512 Intrinsic on RISC-V (openjdk#43)
288f919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicente-romero-oracle vicente-romero-oracle vicente-romero-oracle approved these changes

Assignees
No one assigned
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lahodaj @vicente-romero-oracle