Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266257: Fix foreign linker build issues for ppc and s390 #4303

Closed

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jun 2, 2021

This patch addresses some build issues introduced by integration of JEP-412.
The support for JEP-412 turns some static functions (e.g.float_move, long_move) in sharedRuntime into proper member functions, as they need to be referenced by the new support for Panama upcall handlers. Sadly, not all Hotspot ports agree on the number of parameters these functions take - most notably, ppc and s390 have incompatible signatures, and, because of that, failt to build.

A simpler solution is to move these functions to the x86 macro assembler - after all, these functions are specific to a given platform, and excessive sharing should be avoided. This patch does that - and fixes other remaining issues with non-standard hotspot builds (e.g. by adding stab implementation for some unimplemented Panama support).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266257: Fix foreign linker build issues for ppc and s390

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4303/head:pull/4303
$ git checkout pull/4303

Update a local copy of the PR:
$ git checkout pull/4303
$ git pull https://git.openjdk.java.net/jdk pull/4303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4303

View PR using the GUI difftool:
$ git pr show -t 4303

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4303.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@mcimadamore The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Webrevs

Copy link
Member

@JornVernee JornVernee left a comment

LGTM!

@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266257: Fix foreign linker build issues for ppc and s390

Reviewed-by: jvernee, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 19450b9: 8266281: Assign Symbols to the package selector expression

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
Copy link

@iwanowww iwanowww left a comment

Looks good.

@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented Jun 2, 2021

I just verified that it builds on real machines. Thanks for fixing!

@mcimadamore
Copy link
Contributor Author

mcimadamore commented Jun 3, 2021

/integrate

@openjdk openjdk bot closed this Jun 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 3, 2021
@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@mcimadamore Since your change was applied there have been 27 commits pushed to the master branch:

  • c8f4c02: 8268118: Rename bytes_os_cpu.inline.hpp files to bytes_os_cpu.hpp
  • 1296a6c: 8268119: Rename copy_os_cpu.inline.hpp files to copy_os_cpu.hpp
  • 1783437: 8264975: java/net/DatagramSocket/DatagramSocketMulticasting.java fails infrequently
  • a52a08d: 8267916: Adopt cast notation for CompilerThread conversions
  • 9bf347b: 8226362: langtools ProblemList file contains more than 1 entry for a test
  • bdeaeb4: 8240256: Better resource cleaning for SunPKCS11 Provider
  • 06f87cf: 8266337: ThreadTimesClosure doesn't handle exceptions properly
  • ef01e47: 8268150: tier2: test/jdk/tools/jpackage/junit/junit.java needs updating for jtreg 6
  • e9f3e32: 8259530: Generated docs contain MIT/GPL-licenced works without reproducing the licence
  • d46a2c8: 8268147: need to update reference to testng module for jtreg6
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/a223189b069a7cfe49511d49b5b09e7107cb3cab...master

Your commit was automatically rebased without conflicts.

Pushed as commit 29ab162.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
4 participants