Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263561: Re-examine uses of LinkedList #4304

Closed
wants to merge 11 commits into from
Closed

Conversation

@stsypanov
Copy link
Contributor

@stsypanov stsypanov commented Jun 2, 2021

After I've renamed remove branch GitHub for some reason has closed original #2744, so I've decided to recreate it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4304/head:pull/4304
$ git checkout pull/4304

Update a local copy of the PR:
$ git checkout pull/4304
$ git pull https://git.openjdk.java.net/jdk pull/4304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4304

View PR using the GUI difftool:
$ git pr show -t 4304

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4304.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2021

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@stsypanov The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • net
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 2, 2021

Webrevs

cl4es
cl4es approved these changes Aug 2, 2021
Copy link
Member

@cl4es cl4es left a comment

I always approve of removing LinkedLists and Vectors.

Using ArrayDeque in AbstractPoller seems like the right choice.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@stsypanov this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8263561
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

# Conflicts:
#	src/java.base/share/classes/jdk/internal/util/jar/JarIndex.java
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

⚠️ @stsypanov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8263561
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263561: Re-examine uses of LinkedList

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready and removed merge-conflict labels Aug 2, 2021
@stsypanov
Copy link
Contributor Author

@stsypanov stsypanov commented Aug 2, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@stsypanov
Your change (at version dea42ca) is now ready to be sponsored by a Committer.

@cl4es
Copy link
Member

@cl4es cl4es commented Aug 2, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

Going to push as commit 249d641.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 6a3f834: 8268113: Re-use Long.hashCode() where possible
  • 2536e43: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()
  • 6c4c48f: 8266972: Use String.concat() in j.l.Class where invokedynamic-based String concatenation is not available
  • 72145f3: 8269665: Clean-up toString() methods of some primitive wrappers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 2, 2021

@cl4es @stsypanov Pushed as commit 249d641.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stsypanov stsypanov deleted the 8263561 branch Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants