JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR #4306
Conversation
…E renamed as SCR
|
👋 Welcome back herrick! A progress list of the required criteria for merging this PR into |
|
@andyherrick The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
@andyherrick This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Can we add a simple test for .scr executables? |
8268041: ProblemList runtime/cds/appcds/dynamicArchive/TestDynamicDumpAtOom.java on linux-x64 in -Xcomp Reviewed-by: ccheung
Reviewed-by: chegar
Reviewed-by: chegar
Reviewed-by: erikj
Reviewed-by: stefank, eosterlund
Reviewed-by: tschatzl, mli
Reviewed-by: coleenp, rehn, dholmes, sspitsyn
… and fix failures Reviewed-by: xuelei
Reviewed-by: iklam, coleenp
8266399: Core libs update for JEP 306 Reviewed-by: sadayapalam, bpb, naoto
Reviewed-by: dholmes, hseigel
…tion Co-authored-by: Vladimir Ivanov <vlivanov@openjdk.org> Reviewed-by: vlivanov, kvn
Reviewed-by: mchung, jvernee, vromero
Reviewed-by: jjg
…ect type Reviewed-by: lancea, naoto
Reviewed-by: neliasso, chagedorn
Reviewed-by: psandoz, neliasso
…ectly Co-authored-by: Adam Farley <afarley@openjdk.org> Co-authored-by: Aleksey Shipilev <shade@openjdk.org> Co-authored-by: Nils Eliasson <neliasso@openjdk.org> Reviewed-by: roland
…view) Co-authored-by: Brian Goetz <briangoetz@openjdk.org> Co-authored-by: Mandy Chung <mchung@openjdk.org> Co-authored-by: Jan Lahoda <jlahoda@openjdk.org> Reviewed-by: mcimadamore, forax, godin, psandoz, mchung
Reviewed-by: ayang, tschatzl, kbarrett
Reviewed-by: stefank, dholmes
Reviewed-by: jjg
Reviewed-by: vlivanov, kvn
…art of the decorator set specified at creation. Reviewed-by: dholmes, phh
Reviewed-by: stefank
…Spec Reviewed-by: prappo, darcy
Reviewed-by: ayang, sjohanss
Reviewed-by: zgu
Reviewed-by: jlahoda
… runs Reviewed-by: lancea, jjg, erikj
…_node() Reviewed-by: rkennke, roland
Reviewed-by: sjohanss
…in JTreg compiler tests Co-authored-by: Christian Hagedorn <chagedorn@openjdk.org> Co-authored-by: Tobias Hartmann <thartmann@openjdk.org> Reviewed-by: iignatyev
Reviewed-by: iris, erikj, jjg
Reviewed-by: prr
… streams Reviewed-by: naoto, alanb
|
as suggested added a simple test to verify an app on windows can continue to run after ".exe" is renamed to any other extension |
|
/integrate |
openjdk
bot
added
integrated
|
@andyherrick Since your change was applied there have been 23 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 51e8201. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JDK-8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4306/head:pull/4306$ git checkout pull/4306Update a local copy of the PR:
$ git checkout pull/4306$ git pull https://git.openjdk.java.net/jdk pull/4306/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4306View PR using the GUI difftool:
$ git pr show -t 4306Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4306.diff