-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8264305: Create implementation for native accessibility peer for Statusbar java role #4307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into |
|
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@pankaj-bansal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 114 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@pankaj-bansal Since your change was applied there have been 116 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 3025f05. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Create implementation for native accessibility peer for Statusbar java role. I do not see any Swing component with StatusBar accessibility role, so I have created a component with the StatusBar role to test this. I have tested the implementation with the following example and a few more similar examples. I do not see any difference in Voice Over output.
`
`
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4307/head:pull/4307$ git checkout pull/4307Update a local copy of the PR:
$ git checkout pull/4307$ git pull https://git.openjdk.java.net/jdk pull/4307/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4307View PR using the GUI difftool:
$ git pr show -t 4307Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4307.diff