8268124: Update java.lang to use switch expressions

[pconcannon]

Hi,

Could someone please review my code for updating the code in the java.lang packages to make use of the switch expressions?

Kind regards,
Patrick

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268124: Update java.lang to use switch expressions

Reviewers

• Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to a8706b0
• Joe Darcy (@jddarcy - Reviewer) ⚠️ Review applies to 72c9305
• Mandy Chung (@mlchung - Reviewer) ⚠️ Review applies to df5b34e
• Iris Clark (@irisclark - Reviewer) ⚠️ Review applies to df5b34e
• Lance Andersen (@LanceAndersen - Reviewer) ⚠️ Review applies to df5b34e
• Daniel Fuchs (@dfuch - Reviewer) ⚠️ Review applies to df5b34e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4312/head:pull/4312
$ git checkout pull/4312

Update a local copy of the PR:
$ git checkout pull/4312
$ git pull https://git.openjdk.java.net/jdk pull/4312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4312

View PR using the GUI difftool:
$ git pr show -t 4312

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4312.diff

[bridgekeeper]

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pconcannon The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (c7c11939)
• 04: Full - Incremental (df5b34e5)
• 03: Full - Incremental (7907f3eb)
• 02: Full - Incremental (a8706b02)
• 01: Full - Incremental (d705efbd)
• 00: Full (72c93053)

[naotoj]

Hi Patrick, some minor comments.

[jddarcy]

Changes to Math and Long look fine.

[openjdk]

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268124: Update java.lang to use switch expressions

Reviewed-by: naoto, darcy, mchung, iris, lancea, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[forax]

Looks good to me

[naotoj]

LGTM

[mlchung]

Looks good with one minor comment in DirectMethodHandleDescImpl.java.

[pconcannon]

/integrate

[openjdk]

@pconcannon Since your change was applied there have been 10 commits pushed to the master branch:

• a187fcc: 8238197: JFR: Rework setting and getting EventHandler
• f770f77: 8268390: G1 concurrent gc upgrade to full gc not working
• e0c0b13: 8268534: some serviceability/jvmti tests should be run in driver mode
• 92f0b6d: 8268532: several serviceability/attach tests should be run in driver mode
• 964118f: 8268538: mark hotspot serviceability/logging tests which ignore external VM flags
• 05090fc: 8268536: mark hotspot serviceability/dcmd tests which ignore external VM flags
• ae29f9c: 8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode
• ea19b04: 8268481: Delete JAWT test files for mac
• f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
• ab01cb5: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled

Your commit was automatically rebased without conflicts.

Pushed as commit d43c8a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.