Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268124: Update java.lang to use switch expressions #4312

Closed
wants to merge 7 commits into from

Conversation

@pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Jun 2, 2021

Hi,

Could someone please review my code for updating the code in the java.lang packages to make use of the switch expressions?

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268124: Update java.lang to use switch expressions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4312/head:pull/4312
$ git checkout pull/4312

Update a local copy of the PR:
$ git checkout pull/4312
$ git pull https://git.openjdk.java.net/jdk pull/4312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4312

View PR using the GUI difftool:
$ git pr show -t 4312

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4312.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@pconcannon The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 2, 2021

Loading

Copy link
Member

@naotoj naotoj left a comment

Hi Patrick, some minor comments.

Loading

src/java.base/share/classes/java/lang/CharacterData.java Outdated Show resolved Hide resolved
Loading
Loading
jddarcy
jddarcy approved these changes Jun 2, 2021
Copy link
Member

@jddarcy jddarcy left a comment

Changes to Math and Long look fine.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@pconcannon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268124: Update java.lang to use switch expressions

Reviewed-by: naoto, darcy, mchung, iris, lancea, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 2, 2021
@forax
Copy link
Member

@forax forax commented Jun 3, 2021

Looks good to me

Loading

naotoj
naotoj approved these changes Jun 3, 2021
Copy link
Member

@naotoj naotoj left a comment

LGTM

Loading

mlchung
mlchung approved these changes Jun 3, 2021
Copy link
Member

@mlchung mlchung left a comment

Looks good with one minor comment in DirectMethodHandleDescImpl.java.

Loading

dfuch
dfuch approved these changes Jun 9, 2021
mlchung
mlchung approved these changes Jun 9, 2021
@pconcannon
Copy link
Contributor Author

@pconcannon pconcannon commented Jun 10, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@pconcannon Since your change was applied there have been 10 commits pushed to the master branch:

  • a187fcc: 8238197: JFR: Rework setting and getting EventHandler
  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working
  • e0c0b13: 8268534: some serviceability/jvmti tests should be run in driver mode
  • 92f0b6d: 8268532: several serviceability/attach tests should be run in driver mode
  • 964118f: 8268538: mark hotspot serviceability/logging tests which ignore external VM flags
  • 05090fc: 8268536: mark hotspot serviceability/dcmd tests which ignore external VM flags
  • ae29f9c: 8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode
  • ea19b04: 8268481: Delete JAWT test files for mac
  • f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
  • ab01cb5: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled

Your commit was automatically rebased without conflicts.

Pushed as commit d43c8a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@pconcannon pconcannon deleted the JDK-8268124 branch Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment