Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" #432

Closed
wants to merge 1 commit into from

Conversation

fguallini
Copy link
Contributor

@fguallini fguallini commented Sep 30, 2020

SymmetricRangeTests.java was added to ProblemList as it was throwing OOM time ago. Now, tests have been executed multiple times again with a combination of VM options with 100% pass rate, the issue could not be reproduced anymore, it seems quite stable to be removed from the ProblemList at this time.

Required os.maxMemory has been increased as a preventive measure to run the tests only in an system where memory available is enough to give the JVM some elbow room


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/432/head:pull/432
$ git checkout pull/432

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2020

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2020
@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@fguallini The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 30, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2020

Webrevs

@fguallini fguallini changed the title 8232840: [TESTBUG] java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" 8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" Sep 30, 2020
Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I assume you've run it many times to be sure that 10GB is sufficient.

@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit"

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • 60ec2a5: 8253824: Revert JDK-8253089 since VS warning C4307 has been disabled
  • 90c131f: 8224225: Tokenizer improvements
  • 9670425: 8253822: Remove unused exception_address_is_unpack_entry
  • 8440279: 8180514: TestPrintMdo.java test fails with -XX:-TieredCompilation
  • 44e6820: 8253650: Cleanup: remove alignment_hint parameter from os::reserve_memory
  • ed62b01: 6646602: Spelling error in javadoc for javax.swing.tree.TreeModel
  • 87276bc: 6690021: typos in TransferHandler Javadoc
  • dd36d8c: 8253429: Error reporting should report correct state of terminated/aborted threads
  • 2d9fa9d: 8247912: Make narrowOop a scoped enum
  • 928da49: 8253739: java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java fails
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/ec9bee68660acd6abf0b4dd4023ae69514542256...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2020
@fguallini
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@fguallini
Your change (at version e380ae2) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@AlanBateman @fguallini Since your change was applied there have been 72 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit cfd41c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants