New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8232840: java/math/BigInteger/largeMemory/SymmetricRangeTests.java fails due to "OutOfMemoryError: Requested array size exceeds VM limit" #432
Conversation
👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into |
@fguallini The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and I assume you've run it many times to be sure that 10GB is sufficient.
@fguallini This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 71 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@fguallini |
/sponsor |
@AlanBateman @fguallini Since your change was applied there have been 72 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit cfd41c0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
SymmetricRangeTests.java was added to ProblemList as it was throwing OOM time ago. Now, tests have been executed multiple times again with a combination of VM options with 100% pass rate, the issue could not be reproduced anymore, it seems quite stable to be removed from the ProblemList at this time.
Required os.maxMemory has been increased as a preventive measure to run the tests only in an system where memory available is enough to give the JVM some elbow room
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/432/head:pull/432
$ git checkout pull/432