-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8268131: 2 java/foreign tests timed out #4321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Fix problematic case in TestResourceScope
👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into |
@mcimadamore The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Mailing list message from Joe Darcy on core-libs-dev: Can the test cases be broken into pieces or otherwise decomposed into -Joe On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote: |
1 similar comment
Mailing list message from Joe Darcy on core-libs-dev: Can the test cases be broken into pieces or otherwise decomposed into -Joe On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote: |
I believe they can - but it would require more work - for now the goal was to bring tier4 testing back to stable. |
I would definitely prefer to have Tier4 quiet down for the upcoming code fork These two tests were using the default timeout of 120 seconds/2 minutes and I recommend change the timeout from 720 to 240. That will give you a total However, doubling is a good start for a bump. Also, using a higher timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up.
You might starting with 240 instead of 720 for the initial timeout bump.
@mcimadamore This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
I've adjusted timeout to 240, following suggestions - let's see what happens. |
@mcimadamore Since your change was applied there have been 27 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 52d8215. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch increases time out for both TestUpcall and TestDowncall. These tests were already long-running, but with JEP-412, they were beefed up even more, so now they time out on some debug builds.
This patch also address a minor issue in TestResourceScope which can sometimes lead to intermittent failure, depending on how threads are scheduled.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4321/head:pull/4321
$ git checkout pull/4321
Update a local copy of the PR:
$ git checkout pull/4321
$ git pull https://git.openjdk.java.net/jdk pull/4321/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4321
View PR using the GUI difftool:
$ git pr show -t 4321
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4321.diff