Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8268131: 2 java/foreign tests timed out #4321

Closed
wants to merge 2 commits into from
Closed

8268131: 2 java/foreign tests timed out #4321

wants to merge 2 commits into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jun 2, 2021 •
edited by openjdk bot

This patch increases time out for both TestUpcall and TestDowncall. These tests were already long-running, but with JEP-412, they were beefed up even more, so now they time out on some debug builds.

This patch also address a minor issue in TestResourceScope which can sometimes lead to intermittent failure, depending on how threads are scheduled.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4321/head:pull/4321
$ git checkout pull/4321

Update a local copy of the PR:
$ git checkout pull/4321
$ git pull https://git.openjdk.java.net/jdk pull/4321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4321

View PR using the GUI difftool:
$ git pr show -t 4321

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4321.diff

@mcimadamore
* Increase timeout for TestUpcall/Downcall
b432907 
* Fix problematic case in TestResourceScope
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@mcimadamore The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021 •
edited

Webrevs

@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Mailing list message from Joe Darcy on core-libs-dev:

Can the test cases be broken into pieces or otherwise decomposed into
several shorter-running tests?

-Joe

On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote:

1 similar comment
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Mailing list message from Joe Darcy on core-libs-dev:

Can the test cases be broken into pieces or otherwise decomposed into
several shorter-running tests?

-Joe

On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote:

@mcimadamore
Copy link
Contributor Author

Mailing list message from Joe Darcy on core-libs-dev:

Can the test cases be broken into pieces or otherwise decomposed into
several shorter-running tests?

-Joe

On 6/2/2021 2:35 PM, Maurizio Cimadamore wrote:

I believe they can - but it would require more work - for now the goal was to bring tier4 testing back to stable.

@dcubed-ojdk
Copy link
Member

I would definitely prefer to have Tier4 quiet down for the upcoming code fork
so increasing the timeout is good from my GK POV.

These two tests were using the default timeout of 120 seconds/2 minutes and
with a default timeoutFactor of 4 (set by the test task), the total timeout was
480 seconds/8 minutes.

I recommend change the timeout from 720 to 240. That will give you a total
timeout of 960 seconds/16 minutes. For the TestDowncall.java failure, that
should cover that case. For the TestUpcall.java failure, we don't know if
doubling the total timeout will cover that case or not because that test
didn't pass while the timeout handler is running.

However, doubling is a good start for a bump. Also, using a higher timeout
value doesn't hurt anything if the test doesn't timeout.

dcubed-ojdk
dcubed-ojdk approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up.

You might starting with 240 instead of 720 for the initial timeout bump.

@openjdk
Copy link

openjdk bot commented Jun 3, 2021 •
edited

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268131: 2 java/foreign tests timed out

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 5405f98: 8268077: java.util.List missing from Collections Framework Overview
  • 3aa7062: 8262409: sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions. SSL test failures caused by java failed with "Server reported the wrong exception"
  • 5982cfc: 8266317: Vector API enhancements
  • eb385c0: 8268167: MultipleLogins.java failure on macosx-aarch64
  • fbaebd4: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared
  • 338dae4: 8268133: Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • 29ab162: 8266257: Fix foreign linker build issues for ppc and s390
  • c8f4c02: 8268118: Rename bytes_os_cpu.inline.hpp files to bytes_os_cpu.hpp
  • 1296a6c: 8268119: Rename copy_os_cpu.inline.hpp files to copy_os_cpu.hpp
  • 1783437: 8264975: java/net/DatagramSocket/DatagramSocketMulticasting.java fails infrequently
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/508cec7535cd0ad015d566389bc9e5f53ce4103b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2021
@mcimadamore
Copy link
Contributor Author

/integrate

@mcimadamore
Copy link
Contributor Author

mcimadamore commented Jun 3, 2021 •
edited

I've adjusted timeout to 240, following suggestions - let's see what happens.

@openjdk openjdk bot closed this Jun 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Jun 3, 2021
@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@mcimadamore Since your change was applied there have been 27 commits pushed to the master branch:

  • 5405f98: 8268077: java.util.List missing from Collections Framework Overview
  • 3aa7062: 8262409: sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions. SSL test failures caused by java failed with "Server reported the wrong exception"
  • 5982cfc: 8266317: Vector API enhancements
  • eb385c0: 8268167: MultipleLogins.java failure on macosx-aarch64
  • fbaebd4: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared
  • 338dae4: 8268133: Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • 29ab162: 8266257: Fix foreign linker build issues for ppc and s390
  • c8f4c02: 8268118: Rename bytes_os_cpu.inline.hpp files to bytes_os_cpu.hpp
  • 1296a6c: 8268119: Rename copy_os_cpu.inline.hpp files to copy_os_cpu.hpp
  • 1783437: 8264975: java/net/DatagramSocket/DatagramSocketMulticasting.java fails infrequently
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/508cec7535cd0ad015d566389bc9e5f53ce4103b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 52d8215.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcubed-ojdk dcubed-ojdk dcubed-ojdk approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
2 participants
@mcimadamore @dcubed-ojdk