Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268146: fix for JDK-8266254 fails validate-source #4324

Closed

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jun 2, 2021

Please review a fix to add a missing ','


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268146: fix for JDK-8266254 fails validate-source

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4324/head:pull/4324
$ git checkout pull/4324

Update a local copy of the PR:
$ git checkout pull/4324
$ git pull https://git.openjdk.java.net/jdk pull/4324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4324

View PR using the GUI difftool:
$ git pr show -t 4324

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4324.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 2, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 2, 2021
@jonathan-gibbons jonathan-gibbons deleted the 8268146.copyright branch Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant