Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268167: MultipleLogins.java failure on macosx-aarch64 #4333

Closed

Conversation

coffeys
Copy link
Contributor

@coffeys coffeys commented Jun 3, 2021

MultipleLogins.java should skip test where NSS support is not present


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268167: MultipleLogins.java failure on macosx-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4333/head:pull/4333
$ git checkout pull/4333

Update a local copy of the PR:
$ git checkout pull/4333
$ git pull https://git.openjdk.java.net/jdk pull/4333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4333

View PR using the GUI difftool:
$ git pr show -t 4333

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4333.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@coffeys The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jun 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268167: MultipleLogins.java failure on macosx-aarch64

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fbaebd4: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared
  • 338dae4: 8268133: Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • 29ab162: 8266257: Fix foreign linker build issues for ppc and s390

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 3, 2021
@coffeys
Copy link
Contributor Author

@coffeys coffeys commented Jun 3, 2021

/integrate

@openjdk openjdk bot closed this Jun 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@coffeys Since your change was applied there have been 3 commits pushed to the master branch:

  • fbaebd4: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared
  • 338dae4: 8268133: Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • 29ab162: 8266257: Fix foreign linker build issues for ppc and s390

Your commit was automatically rebased without conflicts.

Pushed as commit eb385c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
2 participants