Skip to content

8265444: Javadocs: jdk.jshell - small typo #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jun 3, 2021

Fixing typo in jdk.jshell's javadoc.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4336/head:pull/4336
$ git checkout pull/4336

Update a local copy of the PR:
$ git checkout pull/4336
$ git pull https://git.openjdk.java.net/jdk pull/4336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4336

View PR using the GUI difftool:
$ git pr show -t 4336

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4336.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 3, 2021
@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Jun 3, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265444: Javadocs: jdk.jshell - small typo

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • eb385c0: 8268167: MultipleLogins.java failure on macosx-aarch64
  • fbaebd4: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared
  • 338dae4: 8268133: Update java/net/Authenticator tests to eliminate dependency on sun.net.www.MessageHeader and some other internal APIs
  • 29ab162: 8266257: Fix foreign linker build issues for ppc and s390
  • c8f4c02: 8268118: Rename bytes_os_cpu.inline.hpp files to bytes_os_cpu.hpp
  • 1296a6c: 8268119: Rename copy_os_cpu.inline.hpp files to copy_os_cpu.hpp
  • 1783437: 8264975: java/net/DatagramSocket/DatagramSocketMulticasting.java fails infrequently
  • a52a08d: 8267916: Adopt cast notation for CompilerThread conversions
  • 9bf347b: 8226362: langtools ProblemList file contains more than 1 entry for a test
  • bdeaeb4: 8240256: Better resource cleaning for SunPKCS11 Provider
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/dc19baca3363a105a5cc1dbc02cbe3ea65e1209e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2021
@lahodaj
Copy link
Contributor Author

lahodaj commented Jun 4, 2021

/integrate

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@lahodaj Since your change was applied there have been 45 commits pushed to the master branch:

  • 069f180: 8268174: Move x86-specific stub declarations into stubRoutines_x86.hpp
  • 3025f05: 8264305: Create implementation for native accessibility peer for Statusbar java role
  • e2d5ff9: 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle
  • 1b4378e: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle
  • edca245: 8267917: mark hotspot containers tests which ignore external VM flags
  • 05df172: 8268224: Cleanup references to "strictfp" in core lib comments
  • 516e60a: 8268095: CDS MethodHandle tests should add -XX:-VerifyDependencies
  • c1f3094: 8267939: Clarify the specification of iterator and spliterator forEachRemaining
  • 460ce55: 8266019: StreamResult(File) writes to incorrect file path if # is part of the file path
  • b955865: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass
  • ... and 35 more: https://git.openjdk.java.net/jdk/compare/dc19baca3363a105a5cc1dbc02cbe3ea65e1209e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 40c9e25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants