Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268178: Extract sender frame parsing to CodeBlob::FrameParser #4337

Closed
wants to merge 1 commit into from

Conversation

@luhenry
Copy link
Member

@luhenry luhenry commented Jun 3, 2021

Whether and how a frame is setup is controlled by the code generator
for the specific CodeBlock. The CodeBlock is then in the best place to know how
to parse the sender's frame from the current frame in the given CodeBlock.

This refactoring proposes to extract this parsing out of frame and into a
CodeBlock::FrameParser. This FrameParser is then specialized in the relevant
inherited children of CodeBlock.

This change is to largely facilitate adding new supported cases for JDK-8252417 [1]
like runtime stubs.

[1] https://bugs.openjdk.java.net/browse/JDK-8252417


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268178: Extract sender frame parsing to CodeBlob::FrameParser

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4337/head:pull/4337
$ git checkout pull/4337

Update a local copy of the PR:
$ git checkout pull/4337
$ git pull https://git.openjdk.java.net/jdk pull/4337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4337

View PR using the GUI difftool:
$ git pr show -t 4337

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4337.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@luhenry luhenry force-pushed the codeblob-frameparser branch from 25c2419 to 63e89d8 Jun 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@luhenry this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout codeblob-frameparser
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@luhenry The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jun 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 3, 2021

@luhenry luhenry changed the title 8268178: Extract sender frame parsing to CodeBlock::FrameParser 8268178: Extract sender frame parsing to CodeBlob::FrameParser Jun 3, 2021
int code_size = align_up((int)(10*K), 2*BytesPerWord);
BufferBlob* blob = BufferBlob::create("InlineCacheBuffer", code_size);
if (blob == NULL) {
vm_exit_out_of_memory(code_size, OOM_MALLOC_ERROR, "CodeCache: no room for InlineCacheBuffer");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is VM exit here appropriate?
AFAICS, previously the failure to allocate InlineCacheBuffer was caught in assertion only.

Copy link
Member Author

@luhenry luhenry Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luhenry luhenry force-pushed the codeblob-frameparser branch from 53c879d to 2800cc5 Jun 7, 2021
Whether and how a frame is setup is controlled by the code generator
for the specific CodeBlock. The CodeBlock is then in the best place to know how
to parse the sender's frame from the current frame in the given CodeBlock.

This refactoring proposes to extract this parsing out of `frame` and into a
`CodeBlock::FrameParser`. This FrameParser is then specialized in the relevant
inherited children of CodeBlock.

This change is to largely facilitate adding new supported cases for JDK-8252417
like runtime stubs.
@luhenry luhenry force-pushed the codeblob-frameparser branch from 2800cc5 to 3b44520 Jun 7, 2021
@luhenry
Copy link
Member Author

@luhenry luhenry commented Jun 8, 2021

Closing for now as there are still failing tests which I can't seem to reproduce locally. I'll reopen when I've figured out the root cause.

@luhenry luhenry closed this Jun 8, 2021
@luhenry luhenry deleted the codeblob-frameparser branch Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants