8268178: Extract sender frame parsing to CodeBlob::FrameParser

[luhenry]

Whether and how a frame is setup is controlled by the code generator
for the specific CodeBlock. The CodeBlock is then in the best place to know how
to parse the sender's frame from the current frame in the given CodeBlock.

This refactoring proposes to extract this parsing out of frame and into a
CodeBlock::FrameParser. This FrameParser is then specialized in the relevant
inherited children of CodeBlock.

This change is to largely facilitate adding new supported cases for JDK-8252417 [1]
like runtime stubs.

[1] https://bugs.openjdk.java.net/browse/JDK-8252417

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268178: Extract sender frame parsing to CodeBlob::FrameParser

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4337/head:pull/4337
$ git checkout pull/4337

Update a local copy of the PR:
$ git checkout pull/4337
$ git pull https://git.openjdk.java.net/jdk pull/4337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4337

View PR using the GUI difftool:
$ git pr show -t 4337

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4337.diff

[bridgekeeper]

👋 Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@luhenry this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout codeblob-frameparser
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@luhenry The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (3b445203)
• 03: Full (2800cc50)
• 02: Full - Incremental (53c879d9)
• 01: Full - Incremental (714ec5fb)
• 00: Full (63e89d87)

[jbachorik]

Is VM exit here appropriate?
AFAICS, previously the failure to allocate InlineCacheBuffer was caught in assertion only.

[luhenry]

This is extracted from https://github.com/openjdk/jdk/pull/4337/files#diff-044ffb3850314d23822b79de889820f6432757df5431eac3748a9eb60b1b6899L69-L73.

[luhenry]

Closing for now as there are still failing tests which I can't seem to reproduce locally. I'll reopen when I've figured out the root cause.