-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass #4340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@mlchung Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b955865. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial javadoc change to add a reference to JVMS 4.1 in
Lookup::defineHiddenClass
such that the reference likethis_class
would be referred to JVMS for details.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4340/head:pull/4340
$ git checkout pull/4340
Update a local copy of the PR:
$ git checkout pull/4340
$ git pull https://git.openjdk.java.net/jdk pull/4340/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4340
View PR using the GUI difftool:
$ git pr show -t 4340
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4340.diff