Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268185: Update GitHub Actions for jtreg 6 #4343

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Jun 3, 2021

Please review changes to the GitHub Actions for the repo, to use jtreg 6.

There are three small parts to the change:

  1. The version info is updated in make/conf/test-dependencies
  2. The new make/build.sh script is used to build jtreg, instead of the earlier build-all.sh script
  3. The format of the tag in the jtreg repo is changed to follow OpenJDK conventions.

Tested implicitly with GitHub Actions on my fork, seen here:
https://github.com/jonathan-gibbons/jdk/actions/runs/903574304


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4343/head:pull/4343
$ git checkout pull/4343

Update a local copy of the PR:
$ git checkout pull/4343
$ git pull https://git.openjdk.java.net/jdk pull/4343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4343

View PR using the GUI difftool:
$ git pr show -t 4343

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4343.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 3, 2021
@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jun 3, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268185: Update GitHub Actions for jtreg 6

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • af3df63: 8267598: jpackage removes system libraries from java.library.path

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2021
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jun 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2021
@openjdk
Copy link

openjdk bot commented Jun 3, 2021

@jonathan-gibbons Since your change was applied there have been 2 commits pushed to the master branch:

  • 68ac871: 8268189: ProblemList compiler/intrinsics/bmi/verifycode/BzhiTestI2L.java in -Xcomp mode
  • af3df63: 8267598: jpackage removes system libraries from java.library.path

Your commit was automatically rebased without conflicts.

Pushed as commit e27c4d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the 8268185.github-actions branch June 3, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants