8232948: javac -h should mangle the overload argument signature

[jbf]

When overloaded methods are disambiguated the appended argument signature
should be mangled according to the spec.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8232948: javac -h should mangle the overload argument signature

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4345/head:pull/4345
$ git checkout pull/4345

Update a local copy of the PR:
$ git checkout pull/4345
$ git pull https://git.openjdk.java.net/jdk pull/4345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4345

View PR using the GUI difftool:
$ git pr show -t 4345

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4345.diff

[bridgekeeper]

👋 Welcome back jfranck! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jbf The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b258cc4a)
• 00: Full (36ef2c35)

[openjdk]

@jbf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8232948: javac -h should mangle the overload argument signature

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 140 new commits pushed to the master branch:

• 81600dc: 8191441: (Process) add Readers and Writer access to java.lang.Process streams
• 7e55569: 8261549: Adjust memory size in MTLTexurePool.m
• e663ba9: 8268299: jvms tag produces incorrect URL
• 3396b69: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests
• 270ec97: 8268331: Fix crash in humongous object eager reclaim logging
• ea8274f: 8267875: Shenandoah: Duplicated code in ShenandoahBarrierSetC2::ideal_node()
• a91f971: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs
• 4f9d6b7: 8267465: remove superfluous preview related annotations and test options
• 728a411: 8268018: remove dead code in commitLimitter
• 15715a8: 8267924: Misleading G1 eager reclaim detail logging
• ... and 130 more: https://git.openjdk.java.net/jdk/compare/236bd89dc3be60cac13099618f5e6518437a5098...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jbf]

/integrate

[openjdk]

@jbf Since your change was applied there have been 154 commits pushed to the master branch:

• 89da202: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L&F
• 61ab4b9: 8267564: JDK-8252971 causes SPECjbb2015 socket exceptions on Windows when MKS is installed
• 00c88f7: 8266918: merge_stack in check_code.c add NULL check
• 8105478: 8268165: AsyncLogging will crash if rotate() fails
• fd91b2a: 8265440: IGV: make node selection more visible
• 81bad59: 8257774: G1: Trigger collect when free region count drops below threshold to prevent evacuation failures
• 341f676: 8267908: linux: thread_native_entry can scribble on stack frame
• f40c89e: 8267209: Child threads should defer logging to after child-parent handshake
• ae986bc: 8266749: AArch64: Backtracing broken on PAC enabled systems
• 36c4e5f: 8267187: Remove deprecated constructor for Log
• ... and 144 more: https://git.openjdk.java.net/jdk/compare/236bd89dc3be60cac13099618f5e6518437a5098...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2717fcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.