Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle #4347

Closed

Conversation

@vidmik
Copy link
Contributor

@vidmik vidmik commented Jun 3, 2021

Mimic what's being done on linux-x64 for consistency.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4347/head:pull/4347
$ git checkout pull/4347

Update a local copy of the PR:
$ git checkout pull/4347
$ git pull https://git.openjdk.java.net/jdk pull/4347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4347

View PR using the GUI difftool:
$ git pr show -t 4347

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4347.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 3, 2021

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 3, 2021

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Jun 3, 2021
@vidmik vidmik changed the title WIP: 8268214: Use system zlib and disable dtrace when building linux-aarch… 8268214: Use system zlib and disable dtrace when building linux-aarch… Jun 4, 2021
@vidmik vidmik changed the title 8268214: Use system zlib and disable dtrace when building linux-aarch… 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle Jun 4, 2021
@openjdk openjdk bot added the rfr label Jun 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 4, 2021

Webrevs

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Seems fine - and trivial.

Thanks,
David

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 1b4378e: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle
  • edca245: 8267917: mark hotspot containers tests which ignore external VM flags
  • 05df172: 8268224: Cleanup references to "strictfp" in core lib comments
  • 516e60a: 8268095: CDS MethodHandle tests should add -XX:-VerifyDependencies
  • c1f3094: 8267939: Clarify the specification of iterator and spliterator forEachRemaining
  • 460ce55: 8266019: StreamResult(File) writes to incorrect file path if # is part of the file path
  • b955865: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 4, 2021
@vidmik
Copy link
Contributor Author

@vidmik vidmik commented Jun 4, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@vidmik Since your change was applied there have been 7 commits pushed to the master branch:

  • 1b4378e: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle
  • edca245: 8267917: mark hotspot containers tests which ignore external VM flags
  • 05df172: 8268224: Cleanup references to "strictfp" in core lib comments
  • 516e60a: 8268095: CDS MethodHandle tests should add -XX:-VerifyDependencies
  • c1f3094: 8267939: Clarify the specification of iterator and spliterator forEachRemaining
  • 460ce55: 8266019: StreamResult(File) writes to incorrect file path if # is part of the file path
  • b955865: 8267995: Add reference to JVMS class file format in Lookup::defineHiddenClass

Your commit was automatically rebased without conflicts.

Pushed as commit e2d5ff9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants