New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268224: Cleanup references to "strictfp" in core lib comments #4349
Conversation
|
PS I'll re-flow the paragraph before pushing. I left them un-re-flowed to ease review. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I note that strictfp
occurs in a few other places, notably two files in java.lang.reflect
. But (as you explain) those occurrences are necessary to support the contents of old-format class files.
@jddarcy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
/integrate |
With the right baseline this time, as noticed by John Rose, after JEP 306 removing non-strict floating-point was integrated, a few stale references were left to "strictfp" and "value sets" in core library comments. This changeset removes those stray references.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4349/head:pull/4349
$ git checkout pull/4349
Update a local copy of the PR:
$ git checkout pull/4349
$ git pull https://git.openjdk.java.net/jdk pull/4349/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4349
View PR using the GUI difftool:
$ git pr show -t 4349
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4349.diff