Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8268227: java/foreign/TestUpcall.java still times out #4355

Closed
wants to merge 1 commit into from
Closed

8268227: java/foreign/TestUpcall.java still times out #4355

wants to merge 1 commit into from

Conversation

mcimadamore
Copy link
Contributor

@mcimadamore mcimadamore commented Jun 4, 2021 •
edited by openjdk bot

Turns out that adding more timeout is a lost cause here. The root cause of the slowdown when running the test in debug build is:

https://bugs.openjdk.java.net/browse/JDK-8266074

Which has also caused related test issues:

https://bugs.openjdk.java.net/browse/JDK-8268095

So, the fix (at least temporarily) is to run method handle-heavy tests with the -XX:-VerifyDependency options.

On my machine, execution time of these tests on debug goes from 10 minutes down to less than 1.

Since -XX:-VerifyDependencies cannot be specified on non-debug build, the -XX:+IgnoreUnrecognizedVMOptions is also passed (thanks Vlad for the tip!).

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268227: java/foreign/TestUpcall.java still times out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4355/head:pull/4355
$ git checkout pull/4355

Update a local copy of the PR:
$ git checkout pull/4355
$ git pull https://git.openjdk.java.net/jdk pull/4355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4355

View PR using the GUI difftool:
$ git pr show -t 4355

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4355.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2021

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@mcimadamore The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 4, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2021

Webrevs

dcubed-ojdk
dcubed-ojdk approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up!

-XX:-VerifyDependencies is useful for getting around the non-release
bits slowness added by the new CHA based stuff added by:
JDK-8266074 Vtable-based CHA implementation

@openjdk
Copy link

openjdk bot commented Jun 5, 2021 •
edited

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268227: java/foreign/TestUpcall.java still times out

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 6c838c5: 8266846: Add java.time.InstantSource
  • 7f55dc1: 8179880: Refactor javax/security shell tests to plain java tests
  • 7e41ca3: 8266957: SA has not followed JDK-8220587 and JDK-8224965
  • 6ff978a: 8267204: Expose access to underlying streams in Reporter
  • 76b54a1: 8263512: [macos_aarch64] issues with calling va_args functions from invoke_native
  • 4e6748c: 8267687: ModXNode::Ideal optimization is better than Parse::do_irem
  • 48dc72b: 8268272: Remove JDK-8264874 changes because Graal was removed.
  • 20b6312: 8268151: Vector API toShuffle optimization
  • 64ec8b3: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash
  • cd0678f: 8199318: add idempotent copy operation for Map.Entry
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/3025f05970ede82c6f67a0434e33b27205e10130...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 5, 2021
@dcubed-ojdk
Copy link
Member

@mcimadamore - Can you please integrate this fix?

@mlbridge
Copy link

mlbridge bot commented Jun 8, 2021

Mailing list message from David Holmes on core-libs-dev:

On 8/06/2021 5:23 am, Daniel D.Daugherty wrote:

On Fri, 4 Jun 2021 10:53:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

Turns out that adding more timeout is a lost cause here. The root cause of the slowdown when running the test in debug build is:

https://bugs.openjdk.java.net/browse/JDK-8266074

Which has also caused related test issues:

https://bugs.openjdk.java.net/browse/JDK-8268095

So, the fix (at least temporarily) is to run method handle-heavy tests with the -XX:-VerifyDependency options.

On my machine, execution time of these tests on debug goes from 10 minutes down to less than 1.

Since `-XX:-VerifyDependencies` cannot be specified on non-debug build, the `-XX:+IgnoreUnrecognizedVMOptions` is also passed (thanks Vlad for the tip!).

@mcimadamore - Can you please integrate this fix?

I see this test failing on Windows in GHA for tier1.

David
-----

1 similar comment
@mlbridge
Copy link

mlbridge bot commented Jun 8, 2021

Mailing list message from David Holmes on core-libs-dev:

On 8/06/2021 5:23 am, Daniel D.Daugherty wrote:

On Fri, 4 Jun 2021 10:53:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

Turns out that adding more timeout is a lost cause here. The root cause of the slowdown when running the test in debug build is:

https://bugs.openjdk.java.net/browse/JDK-8266074

Which has also caused related test issues:

https://bugs.openjdk.java.net/browse/JDK-8268095

So, the fix (at least temporarily) is to run method handle-heavy tests with the -XX:-VerifyDependency options.

On my machine, execution time of these tests on debug goes from 10 minutes down to less than 1.

Since `-XX:-VerifyDependencies` cannot be specified on non-debug build, the `-XX:+IgnoreUnrecognizedVMOptions` is also passed (thanks Vlad for the tip!).

@mcimadamore - Can you please integrate this fix?

I see this test failing on Windows in GHA for tier1.

David
-----

@mcimadamore
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jun 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2021
@openjdk
Copy link

openjdk bot commented Jun 8, 2021

@mcimadamore Since your change was applied there have been 60 commits pushed to the master branch:

  • 2717fcb: 8232948: javac -h should mangle the overload argument signature
  • 89da202: 8266159: macOS ARM + Metal pipeline shows artifacts on Swing Menu with Java L&F
  • 61ab4b9: 8267564: JDK-8252971 causes SPECjbb2015 socket exceptions on Windows when MKS is installed
  • 00c88f7: 8266918: merge_stack in check_code.c add NULL check
  • 8105478: 8268165: AsyncLogging will crash if rotate() fails
  • fd91b2a: 8265440: IGV: make node selection more visible
  • 81bad59: 8257774: G1: Trigger collect when free region count drops below threshold to prevent evacuation failures
  • 341f676: 8267908: linux: thread_native_entry can scribble on stack frame
  • f40c89e: 8267209: Child threads should defer logging to after child-parent handshake
  • ae986bc: 8266749: AArch64: Backtracing broken on PAC enabled systems
  • ... and 50 more: https://git.openjdk.java.net/jdk/compare/3025f05970ede82c6f67a0434e33b27205e10130...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6843576.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcubed-ojdk dcubed-ojdk dcubed-ojdk approved these changes

Assignees
No one assigned
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
2 participants
@mcimadamore @dcubed-ojdk