New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs #4364
Conversation
|
@wangweij This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
@@ -48,9 +48,6 @@ tools/javac/annotations/typeAnnotations/referenceinfos/Lambda.java | |||
tools/javac/annotations/typeAnnotations/referenceinfos/NestedTypes.java 8057687 generic-all emit correct byte code an attributes for type annotations | |||
tools/javac/warnings/suppress/TypeAnnotations.java 8057683 generic-all improve ordering of errors with type annotations | |||
tools/javac/modules/SourceInSymlinkTest.java 8180263 windows-all fails when run on a subst drive | |||
tools/javac/processing/options/XprintRepeatingAnnotations.java 8265611 generic-all @compile/ref comparison fails when noSecurityManager=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe close out JDK-8265611?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you asked, I will close them as "cannot reproduce". :-)
Update: "not an issue" used instead.
/integrate |
@wangweij Since your change was applied there have been 54 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit a91f971. |
Now that the default behavior of JDK 17 is still
-Djava.security.manager=allow
, we can remove the-Djavatest.security.noSecurityManager=true
option from the jtreg command line insideRunTests.gmk
. Three problem-listed langtools tests can also be liberated.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4364/head:pull/4364
$ git checkout pull/4364
Update a local copy of the PR:
$ git checkout pull/4364
$ git pull https://git.openjdk.java.net/jdk pull/4364/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4364
View PR using the GUI difftool:
$ git pr show -t 4364
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4364.diff