Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268272: Remove JDK-8264874 changes because Graal was removed. #4367

Closed
wants to merge 1 commit into from

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Jun 4, 2021

JDK-8264806 removed Graal sources from JDK and INCLUDE_GRAAL is not defined anymore. We can now remove code added by JDK-8264874:
951f277

Tested Tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268272: Remove JDK-8264874 changes because Graal was removed.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4367/head:pull/4367
$ git checkout pull/4367

Update a local copy of the PR:
$ git checkout pull/4367
$ git pull https://git.openjdk.java.net/jdk pull/4367/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4367

View PR using the GUI difftool:
$ git pr show -t 4367

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4367.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 4, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@vnkozlov The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Jun 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 4, 2021

Webrevs

erikj79
erikj79 approved these changes Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268272: Remove JDK-8264874 changes because Graal was removed.

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 20b6312: 8268151: Vector API toShuffle optimization

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 4, 2021
@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Jun 4, 2021

/integrate

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@vnkozlov Since your change was applied there has been 1 commit pushed to the master branch:

  • 20b6312: 8268151: Vector API toShuffle optimization

Your commit was automatically rebased without conflicts.

Pushed as commit 48dc72b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the JDK-8268272 branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants