Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8268279: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails after LibraryLookup is gone #4370

Closed
wants to merge 1 commit into from
Closed

8268279: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails after LibraryLookup is gone #4370

wants to merge 1 commit into from

Conversation

navyxliu
Copy link
Member

@navyxliu navyxliu commented Jun 4, 2021 •
edited by openjdk bot
Loading

LibraryLookup::lookup has been refactored in JDK-8268129. Replace it with SymbolLookup.loaderLookup.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268279: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails after LibraryLookup is gone

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4370/head:pull/4370
$ git checkout pull/4370

Update a local copy of the PR:
$ git checkout pull/4370
$ git pull https://git.openjdk.java.net/jdk pull/4370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4370

View PR using the GUI difftool:
$ git pr show -t 4370

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4370.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2021

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@navyxliu The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jun 4, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2021

Webrevs

zhengyu123
zhengyu123 approved these changes Jun 5, 2021
View reviewed changes
Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Jun 5, 2021 •
edited
Loading

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268279: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails after LibraryLookup is gone

Reviewed-by: zgu, jiefu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • b05fa02: 8267904: C2 crash when compile negative Arrays.copyOf length after loop
  • 95ddf7d: 8267839: trivial mem leak in numa
  • 52d88ee: 8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs
  • 042f0bd: 8256465: [macos] Java frame and dialog presented full screen freeze application
  • 8abf36c: 8268289: build failure due to missing signed flag in x86 evcmpb instruction
  • b05c40c: 8266951: Partial in-lining for vectorized mismatch operation using AVX512 masked instructions
  • f768fbf: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC
  • b2e9eb9: 8268087: Update documentation of the JPasswordField
  • 91f9adc: 8268139: CDS ArchiveBuilder may reference unloaded classes
  • 36bff6f: 8066694: Strange code in JavacParser.java
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/20b631278c0c89ccd9c16f2a29d47eb8414aacd5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@zhengyu123, @DamonFool) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 5, 2021
@navyxliu
Copy link
Member Author

navyxliu commented Jun 5, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 5, 2021
@openjdk
Copy link

openjdk bot commented Jun 5, 2021

@navyxliu
Your change (at version d154ac5) is now ready to be sponsored by a Committer.

@navyxliu
Copy link
Member Author

navyxliu commented Jun 7, 2021

By rules, we need another reviewer/sponsor for this change.
This patch can restore hotspot-tier1 tests. Thanks.

DamonFool
DamonFool approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for fixing it.

@DamonFool
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Jun 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2021
@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@DamonFool @navyxliu Since your change was applied there have been 17 commits pushed to the master branch:

  • b05fa02: 8267904: C2 crash when compile negative Arrays.copyOf length after loop
  • 95ddf7d: 8267839: trivial mem leak in numa
  • 52d88ee: 8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs
  • 042f0bd: 8256465: [macos] Java frame and dialog presented full screen freeze application
  • 8abf36c: 8268289: build failure due to missing signed flag in x86 evcmpb instruction
  • b05c40c: 8266951: Partial in-lining for vectorized mismatch operation using AVX512 masked instructions
  • f768fbf: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC
  • b2e9eb9: 8268087: Update documentation of the JPasswordField
  • 91f9adc: 8268139: CDS ArchiveBuilder may reference unloaded classes
  • 36bff6f: 8066694: Strange code in JavacParser.java
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/20b631278c0c89ccd9c16f2a29d47eb8414aacd5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2aeeeb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamonFool DamonFool DamonFool approved these changes

@zhengyu123 zhengyu123 zhengyu123 approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navyxliu @DamonFool @zhengyu123