Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC #4374

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jun 5, 2021

A trivial fix to ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4374/head:pull/4374
$ git checkout pull/4374

Update a local copy of the PR:
$ git checkout pull/4374
$ git pull https://git.openjdk.java.net/jdk pull/4374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4374

View PR using the GUI difftool:
$ git pr show -t 4374

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4374.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 5, 2021

/label add hotspot-runtime
/label add serviceability
/label add hotspot-gc

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Jun 5, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 5, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@openjdk openjdk bot added the hotspot-gc label Jun 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@dcubed-ojdk
The hotspot-gc label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 5, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 5, 2021

@RogerRiggs - Thanks for the review!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b2e9eb9: 8268087: Update documentation of the JPasswordField
  • 91f9adc: 8268139: CDS ArchiveBuilder may reference unloaded classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 5, 2021
@openjdk openjdk bot closed this Jun 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 5, 2021

@dcubed-ojdk Since your change was applied there have been 2 commits pushed to the master branch:

  • b2e9eb9: 8268087: Update documentation of the JPasswordField
  • 91f9adc: 8268139: CDS ArchiveBuilder may reference unloaded classes

Your commit was automatically rebased without conflicts.

Pushed as commit f768fbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8268286 branch Jun 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 9, 2021

Mailing list message from Andrew Haley on hotspot-runtime-dev:

On 6/5/21 4:21 PM, Daniel D.Daugherty wrote:

What is the actual bug? I just ran this test with ZGC/Linux/AArch64 and it seems to
be fine.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

1 similar comment
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 9, 2021

Mailing list message from Andrew Haley on hotspot-runtime-dev:

On 6/5/21 4:21 PM, Daniel D.Daugherty wrote:

What is the actual bug? I just ran this test with ZGC/Linux/AArch64 and it seems to
be fine.

--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 10, 2021

This PR is for https://bugs.openjdk.java.net/browse/JDK-8268286 which is a
subtask of https://bugs.openjdk.java.net/browse/JDK-8268283. So the bug
is described by:

JDK-8268283 serviceability/sa/TestJmapCore.java failed with zgc on linux-aarch64 after JDK-8266957

Hopefully that answers your question.

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 10, 2021

@theRealAph Also, it seems to fail about 25% of the time, so not surprising if you didn't see it fail unless you ran it at least a few times.

@theRealAph
Copy link
Contributor

@theRealAph theRealAph commented Jun 11, 2021

Sort of. I'm trying to understand what can be AArch64-specific about any of this. If it's an AArch64-back-end-specific bug I'd like to know.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Jun 11, 2021

It's only ProblemListed on linux-aarch64 because that's the only place
where we've seen the issue in Mach5. It's just that simple. Doesn't mean
that it won't show up on any other config with enough runs.

@plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 11, 2021

This is an SA bug, so it could be an issue with the aarch64 support in SA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants