Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs #4377

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 6, 2021

Please review this trivial change.
Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4377/head:pull/4377
$ git checkout pull/4377

Update a local copy of the PR:
$ git checkout pull/4377
$ git pull https://git.openjdk.java.net/jdk pull/4377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4377

View PR using the GUI difftool:
$ git pr show -t 4377

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4377.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2021
@openjdk
Copy link

openjdk bot commented Jun 6, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 6, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Thumbs up.

This is a trivial fix and does not have to wait for 24 hours.

@openjdk
Copy link

openjdk bot commented Jun 6, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 6, 2021
@DamonFool
Copy link
Member Author

DamonFool commented Jun 6, 2021

Thanks @dcubed-ojdk .
/integrate

@openjdk openjdk bot closed this Jun 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2021
@openjdk
Copy link

openjdk bot commented Jun 6, 2021

@DamonFool Pushed as commit 52d88ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8268292 branch Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants