-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904 #4384
Conversation
…after loop" This reverts commit b05fa02.
👋 Welcome back hshi! A progress list of the required criteria for merging this PR into |
@huishi-hs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Please, fix PR's title - it is truncated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The back-out change looks correct.
The JBS title needs to be changed to match the PR title, right? |
@huishi-hs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @dean-long) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I think you’re good to integrate now. |
gc/shenandoah/compiler/TestLinkToNativeRBP.java failes on LinuxX64 and MacOs X64. Might releated with https://bugs.openjdk.java.net/browse/JDK-8268279. Tested locally on LinuxX64 it fails with/without this revert. |
/integrate |
@huishi-hs |
/sponsor |
@DamonFool @huishi-hs Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 3e48244. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…after loop"
This reverts commit b05fa02.
This trigger an assertion in Oracle Closed test, see JBS https://bugs.openjdk.java.net/browse/JDK-8268301
will submit again after fixing.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4384/head:pull/4384
$ git checkout pull/4384
Update a local copy of the PR:
$ git checkout pull/4384
$ git pull https://git.openjdk.java.net/jdk pull/4384/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4384
View PR using the GUI difftool:
$ git pr show -t 4384
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4384.diff