Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904 #4384

Closed
wants to merge 1 commit into from

Conversation

huishi-hs
Copy link

@huishi-hs huishi-hs commented Jun 7, 2021

…after loop"

This reverts commit b05fa02.

This trigger an assertion in Oracle Closed test, see JBS https://bugs.openjdk.java.net/browse/JDK-8268301

will submit again after fixing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4384/head:pull/4384
$ git checkout pull/4384

Update a local copy of the PR:
$ git checkout pull/4384
$ git pull https://git.openjdk.java.net/jdk pull/4384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4384

View PR using the GUI difftool:
$ git pr show -t 4384

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4384.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2021

👋 Welcome back hshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@huishi-hs The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jun 7, 2021
@huishi-hs huishi-hs changed the title Revert "8267904: C2 crash when compile negative Arrays.copyOf length … 8268301: Revert "8267904: C2 crash when compile negative Arrays.copyOf length … Jun 7, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 7, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Please, fix PR's title - it is truncated.

Copy link
Member

@dean-long dean-long left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The back-out change looks correct.

@dean-long
Copy link
Member

The JBS title needs to be changed to match the PR title, right?

@huishi-hs huishi-hs changed the title 8268301: Revert "8267904: C2 crash when compile negative Arrays.copyOf length … 8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904 Jun 7, 2021
@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@huishi-hs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268301: Closed test: compiler/c2/6371167/Test.java fails after JDK-8267904

Reviewed-by: kvn, dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2aeeeb4: 8268279: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails after LibraryLookup is gone

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @dean-long) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2021
@dean-long
Copy link
Member

I think you’re good to integrate now.

@huishi-hs
Copy link
Author

gc/shenandoah/compiler/TestLinkToNativeRBP.java failes on LinuxX64 and MacOs X64. Might releated with https://bugs.openjdk.java.net/browse/JDK-8268279.

Tested locally on LinuxX64 it fails with/without this revert.

@huishi-hs
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 7, 2021
@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@huishi-hs
Your change (at version a141f10) is now ready to be sponsored by a Committer.

@DamonFool
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Jun 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2021
@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@DamonFool @huishi-hs Since your change was applied there have been 2 commits pushed to the master branch:

  • 204b492: 8267703: runtime/cds/appcds/cacheObject/HeapFragmentationTest.java crashed with OutOfMemory
  • 2aeeeb4: 8268279: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails after LibraryLookup is gone

Your commit was automatically rebased without conflicts.

Pushed as commit 3e48244.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants