8268333: javac crashes when pattern matching switch contains default case which is not last

[lahodaj]

The pattern matching switch desugaring should recognize cases where there is default case followed by a type pattern case, and not replace the type pattern with another default.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268333: javac crashes when pattern matching switch contains default case which is not last

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4397/head:pull/4397
$ git checkout pull/4397

Update a local copy of the PR:
$ git checkout pull/4397
$ git pull https://git.openjdk.java.net/jdk pull/4397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4397

View PR using the GUI difftool:
$ git pr show -t 4397

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4397.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (02be7240)

[vicente-romero-oracle]

lgtm

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268333: javac crashes when pattern matching switch contains default case which is not last

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

• 7400789: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
• a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
• 0a6c7d8: 8267424: CTW: C1 fails with "State must not be null"
• e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
• 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
• 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
• f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
• f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
• 6c552a7: 8268544: some runtime/sealedClasses tests should be run in driver mode
• f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
• ... and 96 more: https://git.openjdk.java.net/jdk/compare/908aca29ca60f5f251df8c6a31b2543929be12fc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

Thanks for the review, Vicente. I would prefer to push this into JDK 17, however so I had to create a new PR here:
openjdk/jdk17#26

Could you please transfer your approval there? Thanks!