8263203: jconsole Online User Guide has wrong URL

[plummercj]

The URL for the users guide, referenced from both the About dialog and from the "Help -> Online Users Guide" menu item, has not functioned for a few releases due the restructuring of the JDK online docs. This PR fixes the URL. Note I also filed JDK-8268351 to get rid of the URL, but for 17 I prefer to just fix the URL.

BTW, the change to MANAGE_HOTSPOT_MBEANS_IN_COLON_ is just my editor automatically getting rid of an extra space at the end of the line.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263203: jconsole Online User Guide has wrong URL

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4399/head:pull/4399
$ git checkout pull/4399

Update a local copy of the PR:
$ git checkout pull/4399
$ git pull https://git.openjdk.java.net/jdk pull/4399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4399

View PR using the GUI difftool:
$ git pr show -t 4399

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4399.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d29e0ddb)
• 00: Full (f1342735)

[mlchung]

Hi Chris,

It has been a while but I think this may intend to link to the User Guide (not the tool reference)
https://docs.oracle.com/en/java/javase/16/management/using-jconsole.html

[plummercj]

Hi Chris,

It has been a while but I think this may intend to link to the User Guide (not the tool reference)
https://docs.oracle.com/en/java/javase/16/management/using-jconsole.html

I think you are right. And there is a reference to jconsole.html from using-jconsole.html, so you can still get to it. I'll make the switch.

[plummercj]

...although I'm uncertain how to get to .../management/using-jconsole.html using the "lookup" syntax as was done for getting to jconsole.html. Will need to ask someone on the docs teame.

[mlbridge]

Mailing list message from Mandy Chung on serviceability-dev:

Try "using_jconsole"

Mandy

On 6/7/21 2:09 PM, Chris Plummer wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20210607/a8880aea/attachment-0001.htm>

[mlbridge]

Mailing list message from Mandy Chung on serviceability-dev:

Try "using_jconsole"

Mandy

On 6/7/21 2:09 PM, Chris Plummer wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20210607/a8880aea/attachment-0001.htm>

[plummercj]

Try "using_jconsole"

I already did. No luck.

[plummercj]

Actually that does work. My URL was using 17, which doesn't exist yet, but it seems to work with 16.

[mlchung]

Looks good.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263203: jconsole Online User Guide has wrong URL

Reviewed-by: mchung, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

• 1c3932f: 8264766: ClassCastException during template compilation (Variable cannot be cast to Param)
• f6f82c3: 8266421: Deadlock in Sound System
• bcaa2cb: 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages
• ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
• 5ad4a91: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
• 7a37816: 8264866: Remove unneeded WorkArounds.isAutomaticModule
• 51e8201: 8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR
• f9b593d: 8266748: Move modifiers code to Signatures.java
• 4dd0e7e: 8259806: Clean up terminology on the "All Classes" page
• dc6c96b: 8263468: New page for "recent" new API
• ... and 75 more: https://git.openjdk.java.net/jdk/compare/9f05c411e6d6bdf612cf0cf8b9fe4ca9ecde50d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

No objection to this change but I think we should create a follow-on issue to drop this link from the About page. That will also avoid needing to periodically test that the link still works.

Update: I see JDK-8268351 is created - good.

[plummercj]

Thanks Mandy!

Can I get one more review please?

[dholmes-ora]

LGTM!

Thanks,
David

[plummercj]

/integrate

[openjdk]

@plummercj Since your change was applied there have been 105 commits pushed to the master branch:

• 33d34c6: 8263323: Debug Agent help output includes invalid URL
• 79010f2: 8266835: Add a --validate option to the jar tool
• db45ff0: 8268052: [JVMCI] non-default installed code must be marked as in_use
• bb3d226: 8238213: Method resolution should stop on static error
• 81fdeb5: 8268417: Add test from JDK-8268360
• caf7f49: 8268122: Add specific gc cause for G1 full collections
• 43e38a1: 8268377: Windows 32bit build fails after JDK-8268174
• 5fbb62c: 8268163: Change the order of fallback full GCs in G1
• 7b1e402: 8266598: Exception values for AnnotationTypeMismatchException are not always informative
• 13d6180: 8264859: Implement Context-Specific Deserialization Filters
• ... and 95 more: https://git.openjdk.java.net/jdk/compare/9f05c411e6d6bdf612cf0cf8b9fe4ca9ecde50d1...master

Your commit was automatically rebased without conflicts.

Pushed as commit bbd0313.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.