-
Notifications
You must be signed in to change notification settings - Fork 6.1k
JDK-8267187: Remove deprecated constructor for Log #4404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8267187: Remove deprecated constructor for Log #4404
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@jonathan-gibbons Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 36c4e5f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a change to remove a deprecated constructor in Log, which used to be needed by javadoc.
A previous version of this (#4037) caused problems for javadoc, which have now been addressed in separate updates, and so finally, this constructor can safely be removed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4404/head:pull/4404
$ git checkout pull/4404
Update a local copy of the PR:
$ git checkout pull/4404
$ git pull https://git.openjdk.java.net/jdk pull/4404/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4404
View PR using the GUI difftool:
$ git pr show -t 4404
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4404.diff