8268017: C2: assert(phi_type->isa_int() || phi_type->isa_ptr() || phi_type->isa_long()) failed: bad phi type

[rwestrel]

PhiNode::Ideal() needs to support Cast nodes that were added recently.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268017: C2: assert(phi_type->isa_int() || phi_type->isa_ptr() || phi_type->isa_long()) failed: bad phi type

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)
• Wang Huang (@Wanghuang-Huawei - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4409/head:pull/4409
$ git checkout pull/4409

Update a local copy of the PR:
$ git checkout pull/4409
$ git pull https://git.openjdk.java.net/jdk pull/4409/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4409

View PR using the GUI difftool:
$ git pr show -t 4409

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4409.diff

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0e3c2d2a)

[iwanowww]

Looks good.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268017: C2: assert(phi_type->isa_int() || phi_type->isa_ptr() || phi_type->isa_long()) failed: bad phi type

Reviewed-by: vlivanov, chagedorn, whuang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 2bfd708: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be
• 4d1cf51: 8240349: jlink should not leave partial image output directory on failure
• 07108c9: 8268241: deprecate JVM TI Heap functions 1.0
• c9dbc4f: 8266891: Provide a switch to force the class space to a specific location
• 2cc1977: 8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774
• 58a59e3: 8240997: Remove more "hack" word in security codes
• 1c3932f: 8264766: ClassCastException during template compilation (Variable cannot be cast to Param)
• f6f82c3: 8266421: Deadlock in Sound System
• bcaa2cb: 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages
• ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/00c88f79b30d7867be4a66317b90b9ba7e947f4f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[chhagedorn]

Looks good.

[Wanghuang-Huawei]

Looks good to me.

[rwestrel]

@iwanowww @chhagedorn @Wanghuang-Huawei thanks for the reviews

[rwestrel]

/integrate

[openjdk]

@rwestrel Since your change was applied there have been 25 commits pushed to the master branch:

• 2bfd708: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be
• 4d1cf51: 8240349: jlink should not leave partial image output directory on failure
• 07108c9: 8268241: deprecate JVM TI Heap functions 1.0
• c9dbc4f: 8266891: Provide a switch to force the class space to a specific location
• 2cc1977: 8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774
• 58a59e3: 8240997: Remove more "hack" word in security codes
• 1c3932f: 8264766: ClassCastException during template compilation (Variable cannot be cast to Param)
• f6f82c3: 8266421: Deadlock in Sound System
• bcaa2cb: 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages
• ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
• ... and 15 more: https://git.openjdk.java.net/jdk/compare/00c88f79b30d7867be4a66317b90b9ba7e947f4f...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4413142.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.