-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268372: ZGC: dynamically select the number of concurrent GC threads used #4410
Conversation
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/contributor add pliden |
@albertnetymk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks for the review. /integrate |
@albertnetymk Since your change was applied there have been 42 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit dd34a4c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mailing list message from charlie hunt on hotspot-gc-dev: Nice to see this integrated. Great work! charlie On 6/9/21 5:40 AM, Albert Mingkun Yang wrote: |
1 similar comment
Mailing list message from charlie hunt on hotspot-gc-dev: Nice to see this integrated. Great work! charlie On 6/9/21 5:40 AM, Albert Mingkun Yang wrote: |
Thank you, and your help along the way is greatly appreciated. |
This patch adds support for dynamically selecting the number of GC threads to ZGC.
[1, ConcGCThreads]
) is dynamically selected for each GC cycle.Progress
Issue
Reviewers
Contributors
<pliden@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4410/head:pull/4410
$ git checkout pull/4410
Update a local copy of the PR:
$ git checkout pull/4410
$ git pull https://git.openjdk.java.net/jdk pull/4410/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4410
View PR using the GUI difftool:
$ git pr show -t 4410
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4410.diff