Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility #4412

Closed
wants to merge 15 commits into from
+4,776 −230
Closed

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility #4412

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c05c814
8267385: Create NSAccessibilityElement implementation for JavaCompone…
savoptik Jun 8, 2021
66ce693
8262031: Create implementation for NSAccessibilityNavigableStaticText…
savoptik May 30, 2021
f7979c6
8264287: Create implementation for NSAccessibilityComboBox protocol peer
savoptik May 30, 2021
e8b284f
8264303: Create implementation for NSAccessibilityTabGroup protocol peer
savoptik May 30, 2021
dd219ab
8264292: Create implementation for NSAccessibilityList protocol peer
savoptik May 30, 2021
d74af05
8267387: Create implementation for NSAccessibilityOutline protocol
savoptik May 30, 2021
280ee5f
8267388: Create implementation for NSAccessibilityTable protocol
savoptik May 30, 2021
e9b966b
Even on Linux? I meant if the test will be run on the platform where …
savoptik Jul 2, 2021
ba09569
1. Fixed memory management problems, due to which a11y cells in table…
savoptik Jul 13, 2021
fbe3443
Why not mark them as @Native in the CAccessibility and use constants …
savoptik Jul 14, 2021
76cba14
ok, so this is in the new code, how hard it will be to reimplement th…
savoptik Jul 15, 2021
b4ef57a
1. Removing the warning about an unaccessible element in the console.
savoptik Jul 20, 2021
a07c86d
Wildcard imports are avoided in new tests
savoptik Jul 20, 2021
6505334
1. The comment states that it is not necessary to call ExceptionCheck…
savoptik Jul 21, 2021
a13d6a6
1. Fixed problems with vertical navigation in table cells;
savoptik Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 test/jdk/java/awt/a11y/AccessibleJComboboxTest.java
View file
Open in desktop
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityComboBox protocol peer
Copy link

@pankaj-bansal pankaj-bansal Jul 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary should be something like "Test implementation of NSAccessibilityComboBox protocol peer" or "Test Combobox accessibility"

Copy link
Contributor Author

@savoptik savoptik Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJComboboxTest
Copy link
Member

@mrserb mrserb Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On what platforms these tests are supposed to work?

Copy link
Contributor Author

@savoptik savoptik Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests can be applied wherever a11y support is implemented and running.

Copy link
Member

@mrserb mrserb Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even on Linux? I meant if the test will be run on the platform where a11y is not implemented then this will be reported as a bug. So if on some supported platforms these tests will fail it is better to update the "tags" or the problemlist before integration. Otherwise, people will report new bugs after.

Copy link
Contributor Author

@savoptik savoptik Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
1 test/jdk/java/awt/a11y/AccessibleJListTest.java
View file
Open in desktop
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityList protocol peer
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJListTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
1 test/jdk/java/awt/a11y/AccessibleJTabbedPaneTest.java
View file
Open in desktop
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityTabGroup protocol peer
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJTabbedPaneTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
1 test/jdk/java/awt/a11y/AccessibleJTreeTest.java
View file
Open in desktop
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityOutline protocol
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJTreeTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
1 test/jdk/java/awt/a11y/AccessibleTextTest.java
View file
Open in desktop
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityNavigableStaticText protocol
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleTextTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;