Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267385: Create NSAccessibilityElement implementation for JavaComponentAccessibility #4412

Closed
wants to merge 15 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityComboBox protocol peer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary should be something like "Test implementation of NSAccessibilityComboBox protocol peer" or "Test Combobox accessibility"

Copy link
Contributor Author

@savoptik savoptik Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJComboboxTest
Copy link
Member

@mrserb mrserb Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On what platforms these tests are supposed to work?

Copy link
Contributor Author

@savoptik savoptik Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests can be applied wherever a11y support is implemented and running.

Copy link
Member

@mrserb mrserb Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even on Linux? I meant if the test will be run on the platform where a11y is not implemented then this will be reported as a bug. So if on some supported platforms these tests will fail it is better to update the "tags" or the problemlist before integration. Otherwise, people will report new bugs after.

Copy link
Contributor Author

@savoptik savoptik Jul 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityList protocol peer
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJListTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityTabGroup protocol peer
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJTabbedPaneTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityOutline protocol
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleJTreeTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;
@@ -28,6 +28,7 @@
* @summary Create implementation for NSAccessibilityNavigableStaticText protocol
* @author Artem.Semenov@jetbrains.com
* @run main/manual AccessibleTextTest
* @requires (os.family == "windows" | os.family == "mac")
*/

import javax.swing.*;