Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages #4415

Closed

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Jun 8, 2021

…ages


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4415/head:pull/4415
$ git checkout pull/4415

Update a local copy of the PR:
$ git checkout pull/4415
$ git pull https://git.openjdk.java.net/jdk pull/4415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4415

View PR using the GUI difftool:
$ git pr show -t 4415

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4415.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 8, 2021

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB pack… 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages Jun 8, 2021
@openjdk openjdk bot added the rfr label Jun 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 8, 2021

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jun 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 8, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 8, 2021

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages

Reviewed-by: herrick, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
  • 5ad4a91: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 7a37816: 8264866: Remove unneeded WorkArounds.isAutomaticModule
  • 51e8201: 8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR
  • f9b593d: 8266748: Move modifiers code to Signatures.java
  • 4dd0e7e: 8259806: Clean up terminology on the "All Classes" page
  • dc6c96b: 8263468: New page for "recent" new API
  • fafc4d9: 8268352: Rename javadoc Messager class to JavadocLog

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 8, 2021
@alexeysemenyukoracle
Copy link
Member Author

@alexeysemenyukoracle alexeysemenyukoracle commented Jun 8, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 8, 2021

@alexeysemenyukoracle Since your change was applied there have been 8 commits pushed to the master branch:

  • ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
  • 5ad4a91: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 7a37816: 8264866: Remove unneeded WorkArounds.isAutomaticModule
  • 51e8201: 8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR
  • f9b593d: 8266748: Move modifiers code to Signatures.java
  • 4dd0e7e: 8259806: Clean up terminology on the "All Classes" page
  • dc6c96b: 8263468: New page for "recent" new API
  • fafc4d9: 8268352: Rename javadoc Messager class to JavadocLog

Your commit was automatically rebased without conflicts.

Pushed as commit bcaa2cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants