Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774 #4422

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 9, 2021

Hi all,

A new gc cause called 'G1 Preventive Collection' was added in JDK-8257774.
So the following two jfr tests should also be updated to fix the test failures.

jdk/jfr/event/gc/collection/TestGCCauseWithG1ConcurrentMark.java
jdk/jfr/event/gc/collection/TestGCCauseWithG1FullCollection.java

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4422/head:pull/4422
$ git checkout pull/4422

Update a local copy of the PR:
$ git checkout pull/4422
$ git pull https://git.openjdk.java.net/jdk pull/4422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4422

View PR using the GUI difftool:
$ git pr show -t 4422

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4422.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 9, 2021
@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 9, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jie,

This looks good and trivial IMO.

Thanks for fixing it!

David

@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 58a59e3: 8240997: Remove more "hack" word in security codes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2021
@DamonFool
Copy link
Member Author

Hi Jie,

This looks good and trivial IMO.

Thanks for fixing it!

David

Thanks @dholmes-ora .
/integrate

@openjdk openjdk bot closed this Jun 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Jun 9, 2021
@DamonFool DamonFool deleted the JDK-8268424 branch June 9, 2021 02:23
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 9, 2021
@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@DamonFool Since your change was applied there has been 1 commit pushed to the master branch:

  • 58a59e3: 8240997: Remove more "hack" word in security codes

Your commit was automatically rebased without conflicts.

Pushed as commit 2cc1977.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
2 participants