New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268424: JFR tests fail due to GC cause 'G1 Preventive Collection' not in the valid causes after JDK-8257774 #4422
Conversation
…t in the valid causes after JDK-8257774
|
@DamonFool The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jie,
This looks good and trivial IMO.
Thanks for fixing it!
David
@DamonFool This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks @dholmes-ora . |
@DamonFool Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2cc1977. |
Hi all,
A new gc cause called 'G1 Preventive Collection' was added in JDK-8257774.
So the following two jfr tests should also be updated to fix the test failures.
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4422/head:pull/4422
$ git checkout pull/4422
Update a local copy of the PR:
$ git checkout pull/4422
$ git pull https://git.openjdk.java.net/jdk pull/4422/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4422
View PR using the GUI difftool:
$ git pr show -t 4422
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4422.diff