8253878: clean up nsk/share/jvmti/ArgumentHandler

[iignatev]

Hi all,

could you please review this small patch which reformats ArgumentHandler, removes unused findOptionStringValue(String name, String defaultValue) method, fixes typos?

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253878: clean up nsk/share/jvmti/ArgumentHandler

Reviewers

• Chris Plummer (@plummercj - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/443/head:pull/443
$ git checkout pull/443

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (661fde4)

[plummercj]

Why is this line not indented?

[iignatev]

I guess b/c this is how IDEA thinks @return javadoc should be aligned. I have checked java.base javadoc, and some classes have indentation here, some don't. either way is fine w/ me.

[plummercj]

Ok. I just noticed the indentation was removed and wondered why.

[plummercj]

Shouldn't BadOption use <i> or <code>?

[iignatev]

no, @throws should be followed by exception class-name, see 1

[plummercj]

ok

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253878: clean up nsk/share/jvmti/ArgumentHandler

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
• 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
• ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

thanks Chris.

/integrate

[openjdk]

@iignatev Since your change was applied there have been 3 commits pushed to the master branch:

• 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
• 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
• ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti

Your commit was automatically rebased without conflicts.

Pushed as commit 55c282b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.