Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268461: ARM32: vector intrinsics reaches ShouldNotReachHere #4430

Closed

Conversation

@mychris
Copy link
Member

@mychris mychris commented Jun 9, 2021

This fixes C2 vector intrinsics for 32-bit ARM.
Since the problem exists in mainline, I guess it should be fixed here first and will later be merged into the panama repository.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268461: ARM32: vector intrinsics reaches ShouldNotReachHere

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4430/head:pull/4430
$ git checkout pull/4430

Update a local copy of the PR:
$ git checkout pull/4430
$ git pull https://git.openjdk.java.net/jdk pull/4430/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4430

View PR using the GUI difftool:
$ git pr show -t 4430

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4430.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 9, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@mychris The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 9, 2021

Webrevs

Loading

Copy link
Member

@DamonFool DamonFool left a comment

LGTM

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268461: ARM32: vector intrinsics reaches ShouldNotReachHere

Reviewed-by: jiefu, njian

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 5a66628: 8263107: PSPromotionManager::copy_and_push_safe_barrier needs acquire memory barrier
  • d4377af: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • dd1cbad: 8268285: vmTestbase/nsk/jvmti/GetThreadState/thrstat002 failed with "Wrong thread "thr1" (...) state after SuspendThread"
  • ece3ae3: 8268388: Update large pages information in Java manpage
  • 2623b0b: 8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA
  • f839308: 8268407: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-aarch64 due to JDK-8268211
  • 58ba48b: 8268192: LambdaMetafactory with invokespecial causes VerificationError
  • b41f3f8: 8268478: JVMCI tests failing after JDK-8268052
  • 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
  • 991ca14: 8267430: GraphicsDevice.setDisplayMode(REFRESH_RATE_UNKNOWN) throws IAE: Unable to set display mode!
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/5fbb62c74186417eaeff808ea070b35e5e95267a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@DamonFool, @nsjian) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Jun 10, 2021
nsjian
nsjian approved these changes Jun 10, 2021
@mychris
Copy link
Member Author

@mychris mychris commented Jun 10, 2021

Thanks for the reviews.
@DamonFool Is this trivial enough to integrate right away with only one approval of a reviewer?

Loading

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 10, 2021

Thanks for the reviews.
@DamonFool Is this trivial enough to integrate right away with only one approval of a reviewer?

Yes, it's trivial IMO.
And I think it's fine to go since it has already been reviewed by @nsjian .
Thanks.

Loading

@mychris
Copy link
Member Author

@mychris mychris commented Jun 10, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@mychris
Your change (at version a4bf765) is now ready to be sponsored by a Committer.

Loading

@DamonFool
Copy link
Member

@DamonFool DamonFool commented Jun 10, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@DamonFool @mychris Since your change was applied there have been 21 commits pushed to the master branch:

  • 78b09ab: 8268463: Windows 32bit build fails in DynamicCodeGenerated\libDynamicCodeGenerated.cpp
  • 5a66628: 8263107: PSPromotionManager::copy_and_push_safe_barrier needs acquire memory barrier
  • d4377af: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • dd1cbad: 8268285: vmTestbase/nsk/jvmti/GetThreadState/thrstat002 failed with "Wrong thread "thr1" (...) state after SuspendThread"
  • ece3ae3: 8268388: Update large pages information in Java manpage
  • 2623b0b: 8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA
  • f839308: 8268407: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-aarch64 due to JDK-8268211
  • 58ba48b: 8268192: LambdaMetafactory with invokespecial causes VerificationError
  • b41f3f8: 8268478: JVMCI tests failing after JDK-8268052
  • 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/5fbb62c74186417eaeff808ea070b35e5e95267a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1fd8146.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants