8267424: CTW: C1 fails with "State must not be null"

[veresov]

Range check elimination may need a block at the root of the compilation to insert its predicates. Make sure we have one.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267424: CTW: C1 fails with "State must not be null"

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4437/head:pull/4437
$ git checkout pull/4437

Update a local copy of the PR:
$ git checkout pull/4437
$ git pull https://git.openjdk.java.net/jdk pull/4437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4437

View PR using the GUI difftool:
$ git pr show -t 4437

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4437.diff

[bridgekeeper]

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@veresov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bad929ab)

[vnkozlov]

Good.

[openjdk]

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267424: CTW: C1 fails with "State must not be null"

Reviewed-by: kvn, roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 5a66628: 8263107: PSPromotionManager::copy_and_push_safe_barrier needs acquire memory barrier
• d4377af: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
• dd1cbad: 8268285: vmTestbase/nsk/jvmti/GetThreadState/thrstat002 failed with "Wrong thread "thr1" (...) state after SuspendThread"
• ece3ae3: 8268388: Update large pages information in Java manpage
• 2623b0b: 8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA
• f839308: 8268407: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-aarch64 due to JDK-8268211
• 58ba48b: 8268192: LambdaMetafactory with invokespecial causes VerificationError
• b41f3f8: 8268478: JVMCI tests failing after JDK-8268052
• 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
• 991ca14: 8267430: GraphicsDevice.setDisplayMode(REFRESH_RATE_UNKNOWN) throws IAE: Unable to set display mode!
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/db45ff09acbf4f2d824c5c23093d46c048427368...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rwestrel]

Looks good to me.

[veresov]

/integrate

[openjdk]

Going to push as commit 0a6c7d8.
Since your change was applied there have been 37 commits pushed to the master branch:

• e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
• 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
• 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
• f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
• f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
• 6c552a7: 8268544: some runtime/sealedClasses tests should be run in driver mode
• f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
• 6b6ff53: 8268543: some runtime/verifier tests should be run in driver mode
• 0924382: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions
• d43c8a7: 8268124: Update java.lang to use switch expressions
• ... and 27 more: https://git.openjdk.java.net/jdk/compare/db45ff09acbf4f2d824c5c23093d46c048427368...master

Your commit was automatically rebased without conflicts.

[openjdk]

@veresov Pushed as commit 0a6c7d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.