Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268478: JVMCI tests failing after JDK-8268052 #4442

Closed
wants to merge 1 commit into from

Conversation

tkrodriguez
Copy link
Contributor

@tkrodriguez tkrodriguez commented Jun 9, 2021

I was missing a lock acquire in the new make_in_use call. mach5 testing is underway.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4442/head:pull/4442
$ git checkout pull/4442

Update a local copy of the PR:
$ git checkout pull/4442
$ git pull https://git.openjdk.java.net/jdk pull/4442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4442

View PR using the GUI difftool:
$ git pr show -t 4442

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4442.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 9, 2021

👋 Welcome back never! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@tkrodriguez The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jun 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 9, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

@tkrodriguez can you submit just tier1 testing in addition to what is running now to see that issue is fixed?
Big testing have low priority and we may have to wait long time for results.

fisk
fisk approved these changes Jun 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@tkrodriguez This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268478: JVMCI tests failing after JDK-8268052

Reviewed-by: kvn, eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
  • 991ca14: 8267430: GraphicsDevice.setDisplayMode(REFRESH_RATE_UNKNOWN) throws IAE: Unable to set display mode!
  • bf29a01: 8228343: JCMD and attach fail to work across Linux Container boundary
  • 408e0a9: 8255148: Confusing log output: SSLSocket duplex close failed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 9, 2021
@dean-long
Copy link
Member

@dean-long dean-long commented Jun 9, 2021

I didn't see a tier1 test job form Tom so I started tier1 testing.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Testing results are good.

@tkrodriguez
Copy link
Contributor Author

@tkrodriguez tkrodriguez commented Jun 9, 2021

I wondered why the testing job didn’t start immediately. Seems weird to defer tier1 if a tier1 only job would start earlier.

@tkrodriguez
Copy link
Contributor Author

@tkrodriguez tkrodriguez commented Jun 9, 2021

/integrate

@openjdk openjdk bot closed this Jun 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@tkrodriguez Since your change was applied there have been 4 commits pushed to the master branch:

  • 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
  • 991ca14: 8267430: GraphicsDevice.setDisplayMode(REFRESH_RATE_UNKNOWN) throws IAE: Unable to set display mode!
  • bf29a01: 8228343: JCMD and attach fail to work across Linux Container boundary
  • 408e0a9: 8255148: Confusing log output: SSLSocket duplex close failed

Your commit was automatically rebased without conflicts.

Pushed as commit b41f3f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
4 participants