8209092: Remove outdated wording from RC5ParameterSpec

[jackh2000]

The RC5ParameterSpec class description contains the following sentence: "This class can be used to initialize a Cipher object that implements the RC5 algorithm as supplied by RSA Security LLC, or any parties authorized by RSA Security."

The part "as supplied by RSA Security LLC, or any parties authorized by RSA Security." should be removed. We don't generally include information about 3rd-party JCA providers in the standard javadocs. Also the "authorized" part was probably referring to the RC5 patent but that has since expired.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8209092: Remove outdated wording from RC5ParameterSpec

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer) ⚠️ Review applies to ee75475
• Bradford Wetmore (@bradfordwetmore - Reviewer) ⚠️ Review applies to ee75475

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4443/head:pull/4443
$ git checkout pull/4443

Update a local copy of the PR:
$ git checkout pull/4443
$ git pull https://git.openjdk.java.net/jdk pull/4443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4443

View PR using the GUI difftool:
$ git pr show -t 4443

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4443.diff

[bridgekeeper]

👋 Welcome back jackh2000! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jackh2000 The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (1d20ebc9)
• 01: Full - Incremental (bf6b9096)
• 00: Full (ee75475e)

[XueleiFan]

The update looks good to me. A CSR might be required as it is a spec update, although it is just a trivial update.

[openjdk]

@jackh2000 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8209092: Remove outdated wording from RC5ParameterSpec

Reviewed-by: xuelei, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 320 new commits pushed to the master branch:

• 7ff6e7b: 8267954: Shared classes that failed to load should not be loaded again
• 991ca14: 8267430: GraphicsDevice.setDisplayMode(REFRESH_RATE_UNKNOWN) throws IAE: Unable to set display mode!
• bf29a01: 8228343: JCMD and attach fail to work across Linux Container boundary
• 408e0a9: 8255148: Confusing log output: SSLSocket duplex close failed
• bbd0313: 8263203: jconsole Online User Guide has wrong URL
• 33d34c6: 8263323: Debug Agent help output includes invalid URL
• 79010f2: 8266835: Add a --validate option to the jar tool
• db45ff0: 8268052: [JVMCI] non-default installed code must be marked as in_use
• bb3d226: 8238213: Method resolution should stop on static error
• 81fdeb5: 8268417: Add test from JDK-8268360
• ... and 310 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan, @bradfordwetmore) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bradfordwetmore]

Try to keep lines to <= 80 chars. Maybe break after "in"

[jackh2000]

Fixed. I'll check on the CSR.

[seanjmullan]

This class already references RFC 2040 (see line 32) so on that basis a CSR for this specific change is probably not required.

But the "RC5" algorithm is listed as a standard algorithm in the Java Security Standard Algorithm Names specification but the definition does not reference RFC 2040: https://docs.oracle.com/en/java/javase/16/docs/specs/security/standard-names.html#cipher-algorithm-names

Instead it has this description: "Variable-key-size encryption algorithms developed by Ron Rivest for RSA Data Security, Inc.". That definition is somewhat dated and I think we should just replace this with "The RC5 algorithm as specified in RFC 2040" to match what you have in the javadoc. But that type of change probably requires a CSR since it would be modifying that specification.

I think you could either tackle that change as part of this, or file a follow-on issue to update the RC5 algorithm in the Standard Algorithm Names specification.

[bradfordwetmore]

I was also wondering about the CSR, check with the CSR folks.

[bridgekeeper]

@jackh2000 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@jackh2000 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.