Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268520: VirtualSpace::print_on() should be const #4448

Conversation

iklam
Copy link
Member

@iklam iklam commented Jun 9, 2021

Please review this trivial patch. VirtualSpace::print_on() should be const so we can avoid the weird casting in epsilonHeap.cpp


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268520: VirtualSpace::print_on() should be const

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4448/head:pull/4448
$ git checkout pull/4448

Update a local copy of the PR:
$ git checkout pull/4448
$ git pull https://git.openjdk.java.net/jdk pull/4448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4448

View PR using the GUI difftool:
$ git pr show -t 4448

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4448.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 9, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@iklam The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Jun 9, 2021
@iklam iklam marked this pull request as ready for review Jun 9, 2021
@openjdk openjdk bot added the rfr label Jun 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 9, 2021

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks good, and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268520: VirtualSpace::print_on() should be const

Reviewed-by: kbarrett, stuefe, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working
  • e0c0b13: 8268534: some serviceability/jvmti tests should be run in driver mode
  • 92f0b6d: 8268532: several serviceability/attach tests should be run in driver mode
  • 964118f: 8268538: mark hotspot serviceability/logging tests which ignore external VM flags
  • 05090fc: 8268536: mark hotspot serviceability/dcmd tests which ignore external VM flags
  • ae29f9c: 8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode
  • ea19b04: 8268481: Delete JAWT test files for mac
  • f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
  • ab01cb5: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled
  • 1fd8146: 8268461: ARM32: vector intrinsics reaches ShouldNotReachHere
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/991ca14279faa7db5d0afe023e666844f5b3b75b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2021
Copy link
Member

@tstuefe tstuefe left a comment

+1

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm too :)

@iklam
Copy link
Member Author

@iklam iklam commented Jun 14, 2021

Thanks @tstuefe @tschatzl @kimbarrett for the review!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

Going to push as commit ba601b8.
Since your change was applied there have been 48 commits pushed to the master branch:

  • 1ba4e0c: 8257038: Remove expired flags in JDK 18
  • 90c1034: 8268644: ProblemList serviceability/sa/ClhsdbJstackXcompStress.java in -Xcomp mode
  • 5cee23a: 8265518: C1: Intrinsic support for Preconditions.checkIndex
  • a466b49: 8267634: Update --release 17 symbol information for JDK 17 build 26
  • 49112fa: 8265909: build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home
  • 94d0b0f: 8268565: runtime/records/RedefineRecord.java should be run in driver mode
  • df65237: 8267930: Refine code for loading hsdis library
  • 2e900da: 8268574: ProblemList tests failing due to UseBiasedLocking going away
  • 4fd2a14: 8267556: Enhance class paths check during runtime
  • 8c8422e: 8267893: Improve jtreg test failure handler do get native/mixed stack traces for cores and live processes
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/991ca14279faa7db5d0afe023e666844f5b3b75b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 14, 2021
@openjdk openjdk bot added integrated and removed ready labels Jun 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 14, 2021

@iklam Pushed as commit ba601b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot integrated
5 participants