Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267448: Add "ulimit -a" to environment.html #4451

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jun 10, 2021

Hi all,

could you please review this small patch that does $subj?

Thanks,
-- Igor

attn: @plummercj


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4451/head:pull/4451
$ git checkout pull/4451

Update a local copy of the PR:
$ git checkout pull/4451
$ git pull https://git.openjdk.java.net/jdk pull/4451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4451

View PR using the GUI difftool:
$ git pr show -t 4451

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4451.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8267448 8267448: Add "ulimit -a" to environment.html Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jun 10, 2021
@iignatev
Copy link
Member Author

/cc hotspot-dev

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev
The hotspot label was successfully added.

@iignatev iignatev marked this pull request as ready for review June 10, 2021 08:30
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2021

Webrevs

@iignatev
Copy link
Member Author

closing in favor of openjdk/jdk17#2

@iignatev iignatev closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review
1 participant