8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode

[iignatev]

Hi all,

could you please review this small and test-only change for resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java test?

the test's main class just orchestrates execution and hence should be run in a driver mode, the patch also makes small refactoring of the test code: removes redundant imports, simplifies process creation, and adds checks of the exit code.

testing: resourcehogs/serviceability tests on {linux,windows,macosx}-x64

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4452/head:pull/4452
$ git checkout pull/4452

Update a local copy of the PR:
$ git checkout pull/4452
$ git pull https://git.openjdk.java.net/jdk pull/4452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4452

View PR using the GUI difftool:
$ git pr show -t 4452

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4452.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• 2d
• awt
• beans
• build
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah
• sound
• swing

[iignatev]

/cc serviceability

[openjdk]

@iignatev
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 00: Full (c42eaf8d)

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268530: resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java should be run in driver mode

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• ea19b04: 8268481: Delete JAWT test files for mac
• f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
• ab01cb5: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled
• 1fd8146: 8268461: ARM32: vector intrinsics reaches ShouldNotReachHere
• 78b09ab: 8268463: Windows 32bit build fails in DynamicCodeGenerated\libDynamicCodeGenerated.cpp
• 5a66628: 8263107: PSPromotionManager::copy_and_push_safe_barrier needs acquire memory barrier
• d4377af: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

Thanks, Serguei!

/integrate

[openjdk]

@iignatev Since your change was applied there have been 7 commits pushed to the master branch:

• ea19b04: 8268481: Delete JAWT test files for mac
• f271eb8: 8268303: Incorrect casts in JfrWriterHost::write for Ticks and Tickspan
• ab01cb5: 8268339: Upstream: 8267989: Exceptions thrown during upcalls should be handled
• 1fd8146: 8268461: ARM32: vector intrinsics reaches ShouldNotReachHere
• 78b09ab: 8268463: Windows 32bit build fails in DynamicCodeGenerated\libDynamicCodeGenerated.cpp
• 5a66628: 8263107: PSPromotionManager::copy_and_push_safe_barrier needs acquire memory barrier
• d4377af: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint

Your commit was automatically rebased without conflicts.

Pushed as commit ae29f9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.