New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268536: mark hotspot serviceability/dcmd tests which ignore external VM flags #4457
Conversation
👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into |
@iignatev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thank you, Serguei. /integrate |
@iignatev Since your change was applied there have been 8 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 05090fc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
could you please review the patch which adds
@requires vm.flagless
toserviceability/dcmd/gc/RunFinalizationTest.java
andserviceability/dcmd/compiler/CodeHeapAnalyticsParams.java
tests as they completely ignore external vm flags?Thanks,
-- Igor
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4457/head:pull/4457
$ git checkout pull/4457
Update a local copy of the PR:
$ git checkout pull/4457
$ git pull https://git.openjdk.java.net/jdk pull/4457/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4457
View PR using the GUI difftool:
$ git pr show -t 4457
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4457.diff