8268539: several serviceability/sa tests should be run in driver mode

[iignatev]

Hi all,

could you please review this test-only patch that switches the execution mode of several serviceability/sa tests to driver? all these tests seem not to perform actual testing, and just organize other JDK executions and validates their outputs.

ClhsdbDumpclass.java had to be updated to have access to ./jdk/test/lib/apps/LingeredApp.class file. Although this also can be fixed by propagating the classpath setting to javap, using the path to .class file is more clear and relable, and I actually suspect that before javap read not the dumped .class file, but the one from the test's classpath.

Thanks,
-- Igor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268539: several serviceability/sa tests should be run in driver mode

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4460/head:pull/4460
$ git checkout pull/4460

Update a local copy of the PR:
$ git checkout pull/4460
$ git pull https://git.openjdk.java.net/jdk pull/4460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4460

View PR using the GUI difftool:
$ git pr show -t 4460

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4460.diff

[bridgekeeper]

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iignatev The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6947ff29)

[openjdk]

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268539: several serviceability/sa tests should be run in driver mode

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 7400789: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
• a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
• 0a6c7d8: 8267424: CTW: C1 fails with "State must not be null"
• e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
• 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
• 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
• f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
• f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
• 6c552a7: 8268544: some runtime/sealedClasses tests should be run in driver mode
• f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/dd1cbadc82bcecf718b96c833a5845fde79db061...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iignatev]

Thank you, Serguie.

/integrate

[openjdk]

Going to push as commit 78cb677.
Since your change was applied there have been 29 commits pushed to the master branch:

• 7267227: 8268361: Fix the infinite loop in next_line
• b018c45: 8267630: Start of release updates for JDK 18
• 7400789: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
• a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
• 0a6c7d8: 8267424: CTW: C1 fails with "State must not be null"
• e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
• 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
• 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
• f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
• f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
• ... and 19 more: https://git.openjdk.java.net/jdk/compare/dd1cbadc82bcecf718b96c833a5845fde79db061...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iignatev Pushed as commit 78cb677.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.