Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268542: serviceability/logging/TestFullNames.java tests only 1st test case #4461

Closed
wants to merge 1 commit into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jun 10, 2021

Hi all,

could you please review this small fix for serviceability/logging/TestFullNames.java test?
from JBS:

serviceability/logging/TestFullNames.java test contains two test cases: specifying filename w/ and w/o "file=" prefix. yet, the test doesn't remove the file, hence its 2nd test case doesn't really test much.

the patch simply calls File::delete inside the loop and verifies that the file doesn't exist at the beginning of each iteration.

testing: serviceability/logging/TestFullNames.java on {linux,windows,macosx}-x64

Thanks,
-- Igor

/cc hotspot-runtime serviceability


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268542: serviceability/logging/TestFullNames.java tests only 1st test case

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4461/head:pull/4461
$ git checkout pull/4461

Update a local copy of the PR:
$ git checkout pull/4461
$ git pull https://git.openjdk.java.net/jdk pull/4461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4461

View PR using the GUI difftool:
$ git pr show -t 4461

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4461.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8268542 8268542: serviceability/logging/TestFullNames.java tests only 1st test case Jun 10, 2021
@openjdk openjdk bot added rfr hotspot-runtime serviceability labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@iignatev
The hotspot-runtime label was successfully added.

The serviceability label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268542: serviceability/logging/TestFullNames.java tests only 1st test case

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
  • 0a6c7d8: 8267424: CTW: C1 fails with "State must not be null"
  • e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
  • 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
  • 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
  • f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
  • f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
  • 6c552a7: 8268544: some runtime/sealedClasses tests should be run in driver mode
  • f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
  • 6b6ff53: 8268543: some runtime/verifier tests should be run in driver mode
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/e0c0b139d335cd818468db115dd18f1cedf21675...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2021
@iignatev
Copy link
Member Author

@iignatev iignatev commented Jun 10, 2021

Thanks, Serguei!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

Going to push as commit 7400789.
Since your change was applied there have been 14 commits pushed to the master branch:

  • a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
  • 0a6c7d8: 8267424: CTW: C1 fails with "State must not be null"
  • e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
  • 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
  • 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
  • f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
  • f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
  • 6c552a7: 8268544: some runtime/sealedClasses tests should be run in driver mode
  • f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
  • 6b6ff53: 8268543: some runtime/verifier tests should be run in driver mode
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/e0c0b139d335cd818468db115dd18f1cedf21675...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@iignatev Pushed as commit 7400789.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
2 participants