Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268543: some runtime/verifier tests should be run in driver mode #4462

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Jun 10, 2021

Hi all,

could you please review the patch that switches the execution mode in a few runtime/verifier tests to driver?

testing: runtime/verifier on {linux,windows,macosx}-x64

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268543: some runtime/verifier tests should be run in driver mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4462/head:pull/4462
$ git checkout pull/4462

Update a local copy of the PR:
$ git checkout pull/4462
$ git pull https://git.openjdk.java.net/jdk pull/4462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4462

View PR using the GUI difftool:
$ git pr show -t 4462

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4462.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8268543 8268543: some runtime/verifier tests should be run in driver mode Jun 10, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jun 10, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and trivial. Thanks for fixing this.
Harold

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268543: some runtime/verifier tests should be run in driver mode

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 0924382: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions
  • d43c8a7: 8268124: Update java.lang to use switch expressions
  • a187fcc: 8238197: JFR: Rework setting and getting EventHandler
  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 10, 2021
@iignatev
Copy link
Member Author

Thanks, Harold!

/integrate

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@iignatev Since your change was applied there have been 4 commits pushed to the master branch:

  • 0924382: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions
  • d43c8a7: 8268124: Update java.lang to use switch expressions
  • a187fcc: 8238197: JFR: Rework setting and getting EventHandler
  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working

Your commit was automatically rebased without conflicts.

Pushed as commit 6b6ff53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants