Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC #4464

Closed
wants to merge 1 commit into from

Conversation

@lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Jun 10, 2021

(Temporary) Disable ParallelRefProcEnabled for Parallel GC, will make Kitchensink pass.

Tier3 running, will wait for it before integrating.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4464/head:pull/4464
$ git checkout pull/4464

Update a local copy of the PR:
$ git checkout pull/4464
$ git pull https://git.openjdk.java.net/jdk pull/4464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4464

View PR using the GUI difftool:
$ git pr show -t 4464

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4464.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-gc label Jun 10, 2021
Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC

Reviewed-by: stefank, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
  • 6b6ff53: 8268543: some runtime/verifier tests should be run in driver mode
  • 0924382: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions
  • d43c8a7: 8268124: Update java.lang to use switch expressions
  • a187fcc: 8238197: JFR: Rework setting and getting EventHandler
  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working
  • e0c0b13: 8268534: some serviceability/jvmti tests should be run in driver mode
  • 92f0b6d: 8268532: several serviceability/attach tests should be run in driver mode
  • 964118f: 8268538: mark hotspot serviceability/logging tests which ignore external VM flags
  • 05090fc: 8268536: mark hotspot serviceability/dcmd tests which ignore external VM flags
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/5a666282a9e5b5748d85f4c012b36e5c8f7eab56...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

Loading

@lkorinth
Copy link
Contributor Author

@lkorinth lkorinth commented Jun 10, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@lkorinth Since your change was applied there have been 19 commits pushed to the master branch:

  • f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
  • f677163: 8266130: convert Thread-SMR stress tests from counter based to time based
  • 6c552a7: 8268544: some runtime/sealedClasses tests should be run in driver mode
  • f4b3170: 8268428: Test java/foreign/TestResourceScope.java fails: expected [M] but found [N]
  • 6b6ff53: 8268543: some runtime/verifier tests should be run in driver mode
  • 0924382: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions
  • d43c8a7: 8268124: Update java.lang to use switch expressions
  • a187fcc: 8238197: JFR: Rework setting and getting EventHandler
  • f770f77: 8268390: G1 concurrent gc upgrade to full gc not working
  • e0c0b13: 8268534: some serviceability/jvmti tests should be run in driver mode
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/5a666282a9e5b5748d85f4c012b36e5c8f7eab56...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7cd5a6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants