Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268470: CDS dynamic dump asserts with JFR RecordingStream #4467

Closed

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Jun 10, 2021

During JFR startup, it redefines some of the builtin classes like java/lang/Throwable. Later, when a subclass of Throwable is loaded, it will inherit the redefined version of Throwable which will not be inside the buffer space or mapped static archive.

To fix this bug, in SystemDictionaryShared::check_for_exclusion_impl(), instead of only checking if the class has been redefined, it also checks if any of its super types has been redefined. If so, exclude the class from the archive.

  • mach5 tier1, tier2 (including the new test)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268470: CDS dynamic dump asserts with JFR RecordingStream

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4467/head:pull/4467
$ git checkout pull/4467

Update a local copy of the PR:
$ git checkout pull/4467
$ git pull https://git.openjdk.java.net/jdk pull/4467/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4467

View PR using the GUI difftool:
$ git pr show -t 4467

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4467.diff

@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Jun 10, 2021

/label add hotspot-runtime

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@calvinccheung calvinccheung marked this pull request as ready for review Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@calvinccheung
The hotspot-runtime label was successfully added.

Loading

@openjdk openjdk bot added the rfr label Jun 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

Loading

iklam
iklam approved these changes Jun 10, 2021
Copy link
Member

@iklam iklam left a comment

LGTM

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268470: CDS dynamic dump asserts with JFR RecordingStream

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 91 new commits pushed to the master branch:

  • 78cb677: 8268539: several serviceability/sa tests should be run in driver mode
  • 7267227: 8268361: Fix the infinite loop in next_line
  • b018c45: 8267630: Start of release updates for JDK 18
  • 7400789: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
  • a95e64c: 8268443: ParallelGC Full GC should use parallel WeakProcessor
  • 0a6c7d8: 8267424: CTW: C1 fails with "State must not be null"
  • e11f70a: 8003216: Add JFR event indicating explicit System.gc() call
  • 2b41459: 8267073: Race between Card Redirtying and Freeing Collection Set regions results in missing remembered set entries with G1
  • 7cd5a6e: 8268537: (Temporary) Disable ParallelRefProcEnabled for Parallel GC
  • f716711: 8265271: JFR: Allow use of .jfc options when starting JFR
  • ... and 81 more: https://git.openjdk.java.net/jdk/compare/e546ae27ffc6c19ae078a41ab6e1741a104958c1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 10, 2021
@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Jun 10, 2021

@iklam Thanks for your review.
I'll withdraw the PR and rebase it on jdk17 since it is targeted for 17.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants